Re: [PATCH] wine.inf: Change Msi.Package actions to have the full msiexec path. (try 2)
"Lei Zhang" <thestig(a)google.com> writes:
@@ -143,9 +143,9 @@ HKCR,lnkfile\CLSID,,2,"{00021401-0000-0000-C000-000000000046}" HKCR,lnkfile\shellex\IconHandler,,2,"{00021401-0000-0000-C000-000000000046}" HKCR,lnkfile\shellex\ContextMenuHandlers\{00021401-0000-0000-C000-000000000046},,0x10, HKCR,Msi.Package\DefaultIcon,,2,"msiexec.exe" -HKCR,Msi.Package\shell\Open\command,,2,"msiexec /i ""%1""" -HKCR,Msi.Package\shell\Repair\command,,2,"msiexec /f ""%1""" -HKCR,Msi.Package\shell\Uninstall\command,,2,"msiexec /x ""%1""" +HKCR,Msi.Package\shell\Open\command,,0x20000,"""%SystemRoot%\System32\msiexec.exe"" /i ""%1"" %*" +HKCR,Msi.Package\shell\Repair\command,,0x20000,"""%SystemRoot%\System32\msiexec.exe"" /f ""%1"" %*" +HKCR,Msi.Package\shell\Uninstall\command,,0x20000,"""%SystemRoot%\System32\msiexec.exe"" /x ""%1"" %*"
You should be using %11% instead of hardcoding system32, but it shouldn't make any difference either way. Why do you need to change this? -- Alexandre Julliard julliard(a)winehq.org
On Thu, Jul 31, 2008 at 3:11 AM, Alexandre Julliard <julliard(a)winehq.org> wrote:
You should be using %11% instead of hardcoding system32, but it shouldn't make any difference either way. Why do you need to change this?
While mucking around in programs/cmd/wcmdmain.c, I noticed console = SHGetFileInfo(); always returned 0 for just "msiexec". This is part of why running foo.msi from the command prompt does not return immediately, like it does on Windows.
"Lei Zhang" <thestig(a)google.com> writes:
While mucking around in programs/cmd/wcmdmain.c, I noticed console = SHGetFileInfo(); always returned 0 for just "msiexec".
cmd is supposed to build a full path here, but either way it won't work because SHGetFileInfo doesn't work for builtins. This is the real bug that needs fixing. -- Alexandre Julliard julliard(a)winehq.org
On Thu, Jul 31, 2008 at 1:45 PM, Alexandre Julliard <julliard(a)winehq.org> wrote:
"Lei Zhang" <thestig(a)google.com> writes:
While mucking around in programs/cmd/wcmdmain.c, I noticed console = SHGetFileInfo(); always returned 0 for just "msiexec".
cmd is supposed to build a full path here, but either way it won't work because SHGetFileInfo doesn't work for builtins. This is the real bug that needs fixing.
The first bug is in FindExecutuable. On Windows, FindExecutable("msiexec", ...) return the full path, but just msiexec.exe on Wine.
participants (2)
-
Alexandre Julliard -
Lei Zhang