Re: notepad: Use the explicit W-form of the types.

[Reece Dunn]

2009/5/7 Michael Stefaniuc <mstefani(a)redhat.de>:
>         LoadString(Globals.hInstance, STRING_ERROR, szTitle, SIZEOF(szTitle));
>         FormatMessage(
>             FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM,
> -            NULL, error, 0,
> -            (LPTSTR) &lpMsgBuf, 0, NULL);
> +            NULL, error, 0, (LPWSTR)&lpMsgBuf, 0, NULL);

Shouldn't you be using FormatMessageW here?

Also, should the LoadString call be fixed as well?

- Reece

notepad: Use the explicit W-form of the types.

[Michael Stefaniuc]

Reece Dunn wrote:
> 2009/5/7 Michael Stefaniuc <mstefani(a)redhat.de>:
> > LoadString(Globals.hInstance, STRING_ERROR, szTitle, SIZEOF(szTitle));
> >         FormatMessage(
> >             FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM,
> > -            NULL, error, 0,
> > -            (LPTSTR) &lpMsgBuf, 0, NULL);
> > +            NULL, error, 0, (LPWSTR)&lpMsgBuf, 0, NULL);
>
> Shouldn't you be using FormatMessageW here?
>
> Also, should the LoadString call be fixed as well?
> Of course it should. I'm not finished yet; that will be a separate patch.

bye
	michael