Re: [1/4] server: Add support for console font size, maximum window size, etc.

[Dmitry Timoshkov]

Hugh McMaster <hugh.mcmaster(a)masterindexing.com> wrote:
> This patch modifies server/protocol.def and server/console.c to add support
> for console font size detection and console window size rendering. It also
> tidies up a few inconsistencies in the repeated usage of aspects of the
> screen buffer struct.

Your patches are full of formatting and white space changes, please don't do
that.

-- 
Dmitry.

[1/4] server: Add support for console font size, maximum window size, etc.

[Hugh McMaster]

My reasoning was that the order of appearance from the screen buffer struct should be the same each time. The patch adds uniformity, but if that is not wanted, then so be it.

Some of the formatting changes are necessary however, because some of the server operations are performed in a specific order.

Anyway, I can resubmit without the formatting and white space changes, if you think it necessary.

Hugh

-----Original Message-----
From: Dmitry Timoshkov [mailto:dvtimoshkov(a)gmail.com] On Behalf Of Dmitry Timoshkov
Sent: Tuesday, 21 May 2013 12:42 PM
To: Hugh McMaster
Cc: wine-devel(a)winehq.org
Subject: Re: [1/4] server: Add support for console font size, maximum window size, etc.

Hugh McMaster <hugh.mcmaster(a)masterindexing.com> wrote:
> This patch modifies server/protocol.def and server/console.c to add 
> support for console font size detection and console window size 
> rendering. It also tidies up a few inconsistencies in the repeated 
> usage of aspects of the screen buffer struct.

Your patches are full of formatting and white space changes, please don't do that.

--
Dmitry.