[PATCH v2] http.sys: Initialize address structure before use. (Coverity)

[Alistair Leslie-Hughes]

CID 1453504

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>
---
 dlls/http.sys/http.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dlls/http.sys/http.c b/dlls/http.sys/http.c
index b5d5a219dc..02320d487f 100644
--- a/dlls/http.sys/http.c
+++ b/dlls/http.sys/http.c
@@ -1053,6 +1053,7 @@ static NTSTATUS http_add_url(struct request_queue *queue, IRP *irp)
 
     TRACE("host %s, context %s.\n", debugstr_a(params->url), wine_dbgstr_longlong(params->context));
 
+    memset( &addr, 0, sizeof(addr) );
     if (!strncmp(params->url, "https://", 8))
     {
         FIXME("HTTPS is not implemented.\n");
-- 
2.17.1

[Zebediah Figura]

On 9/5/19 10:36 PM, Alistair Leslie-Hughes wrote:
> CID 1453504
>
> Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>
> ---
>  dlls/http.sys/http.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/dlls/http.sys/http.c b/dlls/http.sys/http.c
> index b5d5a219dc..02320d487f 100644
> --- a/dlls/http.sys/http.c
> +++ b/dlls/http.sys/http.c
> @@ -1053,6 +1053,7 @@ static NTSTATUS http_add_url(struct request_queue *queue, IRP *irp)
>
> TRACE("host %s, context %s.\n", debugstr_a(params->url), wine_dbgstr_longlong(params->context));
>
> +    memset( &addr, 0, sizeof(addr) );
>      if (!strncmp(params->url, "https://", 8))
>      {
>          FIXME("HTTPS is not implemented.\n");

Given that the the thing Coverity is complaining about is sin_zero, is
this really a salient warning to fix?

[Alistair Leslie-Hughes]

Hi Zebediah,

On 6/9/19 11:48 pm, Zebediah Figura wrote:
> Given that the the thing Coverity is complaining about is sin_zero, is
> this really a salient warning to fix?

Maybe,  however all the other places, except one, clears the the

sockaddr_in structure first,  the other memset's the sin_zero part.


Regards

Alistair.