Re: try3 [1/2] kernel32/tests: Fix tests to pass on Win9x and WinME

[Alexandre Julliard]

Guy Albertelli <galberte(a)neo.rr.com> writes:
> Changelog
>    - Fix new tests for CreateFileA to pass on Win9x and WinME
>    - Fix tests for when GetVolumeNameForVolumeMountPointA fails.

Please send separate changes as separate patches.
> @@ -829,13 +830,17 @@ static void test_CreateFileA(void)
>          }
>          /* otherwise validate results with expectations */
>          else if (p[i].todo_flag)
> -            todo_wine ok((hFile == INVALID_HANDLE_VALUE && p[i].err == GetLastError()) ||
> +            todo_wine ok(
> +                (hFile == INVALID_HANDLE_VALUE && (p[i].err == GetLastError() ||
> +                  (p[i].err2 == -1 ? TRUE : p[i].err2 == GetLastError()))) ||

Please don't use -1 for DWORD values. Also your check will make the test
useless for cases that have only one possible error.

-- 
Alexandre Julliard
julliard(a)winehq.org