Re: Revert "mshtml: Added support for DOCHOSTUIFLAG_SCROLL_NO DOCHOSTINFO flag."

[Jacek Caban]

Vitaliy Margolen wrote:
> Since Jacek did not comment on the bug 14311, revert patch in question. It
> restores 100% functionality of the scrollbars in Steam.

The fact that I didn't comment doesn't mean anything. I didn't have time 
to work on it and I'm currently looking at it (BTW, with today git other 
Steam bug is fixed). I know that it doesn't make any difference for 
user, but from technical point of view, there was no regression. Steam 
draws its own scrollbars and doesn't use built-in MSHTML scrollbars. 
Previously there were two bugs:
- MSHTML scrollbars were not hidden
- Steam scrollbars didn't work
The patch that you want to revert (with fixes apps like CS3 installer) 
fixed the first problem. Now the second one needs to be fixed.


Jacek

Revert "mshtml: Added support for DOCHOSTUIFLAG_SCROLL_NO DOCHOSTINFO flag."

[Vitaliy Margolen]

Jacek Caban wrote:
> Vitaliy Margolen wrote:
> > Since Jacek did not comment on the bug 14311, revert patch in question. It
> > restores 100% functionality of the scrollbars in Steam.
>
> The fact that I didn't comment doesn't mean anything.
> At least a note that you don't have time would be enough. At least everyone
> will see you know about the problem. And writing few lines sure doesn't take
>  1/2 day <g>.
> BTW, with today git other Steam bug is fixed.
> Thanks, much appreciated. That sure was another show stopper for number of
> users.
> I know that it doesn't make any difference for user, but from technical point
> of view, there was no regression.
> Well regression is a regression. Most in Wine are that way - something got
> fixed / implemented that uncovered yet another problem.

Vitaliy.

Revert "mshtml: Added support for DOCHOSTUIFLAG_SCROLL_NO DOCHOSTINFO flag."

[Alexandre Julliard]

Vitaliy Margolen <wine-devel(a)kievinfo.com> writes:
> Well regression is a regression. Most in Wine are that way - something got
> fixed / implemented that uncovered yet another problem.

Yes, but we don't revert the change in such cases, that would prevent
any progress. Reverting is only appropriate when a patch is demonstrably
broken, not when it's an improvement that causes unfortunate side
effects.

-- 
Alexandre Julliard
julliard(a)winehq.org