Re: Printing bugfixes

[Huw D M Davies]

On Thu, Jan 01, 2004 at 08:23:20PM +0000, Mike Hearn wrote:
> ChangeLog:
> - Write out default printer name in the order used by WinME
> - Support PRINTER_ENUM_DEFAULT
> - Add FIXME for enumerating print providers
>
> I'd appreciate somebody with a CUPs and lpr setup ensuring the order
> change doesn't cause regressions. It appears correct to me, but as the
> code worked before even though it looked like it shouldn't I might be
> wrong.

Actually I don't see why we need a different name and devname we
should just use devname for both entries instead. I think it's a
hangover from some old code

Your patch however looks wrong, you're adding a default printer with
port LPR:LPT1, the spooler will try to print with the command
lpr -PLPT1 which won't work.  You really want to set the port to LPT1:

Huw.

Printing bugfixes

[Mike Hearn]

On Fri, 2004-01-02 at 12:35, Huw D M Davies wrote:
> Actually I don't see why we need a different name and devname we
> should just use devname for both entries instead. I think it's a
> hangover from some old code

OK. I'll resend just using devname.
> Your patch however looks wrong, you're adding a default printer with
> port LPR:LPT1, the spooler will try to print with the command
> lpr -PLPT1 which won't work.  You really want to set the port to LPT1:

You mean in this line?

WINSPOOL_SetDefaultPrinter("LPT1","Wine PostScript Driver", FALSE);

I don't really understand, sorry. You mean it should be like this?

WINSPOOL_SetDefaultPrinter("LPT1:","Wine PostScript Driver", FALSE);

Or that this line:
 sprintf(buf,"%s,WINEPS,LPR:%s",name,devname);
should be
 sprintf(buf,"%s,WINEPS,%s",devname,devname);

thanks -mike

Printing bugfixes

[Huw D M Davies]

On Fri, Jan 02, 2004 at 02:47:04PM +0000, Mike Hearn wrote:
> Or that this line:
>  sprintf(buf,"%s,WINEPS,LPR:%s",name,devname);
> should be
>  sprintf(buf,"%s,WINEPS,%s",devname,devname);

Yes like that, but you'll then have to add the LPR: bit to devname
for the printcap and CUPS cases before the function is called.

Huw.