Re: cryptui: Fix a crash with certification path (resend)

[Alexandre Julliard]

André Hentschel <nerv(a)dawncrow.de> writes:
> @@ -4051,8 +4050,8 @@ static void show_cert_chain(HWND hwnd, struct hierarchy_data *data)
>                   */
>                  tvis.u.item.iImage = 2;
>              }
> -            else if (provSigner->pasCertChain[i - 1].pChainElement->TrustStatus.
> -             dwErrorStatus == 0)
> +            else if (i > 1 &&
> +                     provSigner->pasCertChain[i - 1].pChainElement->TrustStatus.dwErrorStatus == 0)

What is this change for?

-- 
Alexandre Julliard
julliard(a)winehq.org

cryptui: Fix a crash with certification path (resend)

[André Hentschel]

Am 06.10.2010 17:41, schrieb Alexandre Julliard:
> André Hentschel <nerv(a)dawncrow.de> writes:
> > @@ -4051,8 +4050,8 @@ static void show_cert_chain(HWND hwnd, struct hierarchy_data *data)
> >                   */
> >                  tvis.u.item.iImage = 2;
> >              }
> > -            else if (provSigner->pasCertChain[i - 1].pChainElement->TrustStatus.
> > -             dwErrorStatus == 0)
> > +            else if (i > 1 &&
> > +                     provSigner->pasCertChain[i - 1].pChainElement->TrustStatus.dwErrorStatus == 0)
>
> What is this change for?

there is no pasCertChain[0] for some reason, there is a similar check in show_dialog_for_selected_cert (same file, "selection" is checked for not being 0 and used as index for pasCertChain)

-- 

Best Regards, André Hentschel

cryptui: Fix a crash with certification path (resend)

[Juan Lang]

> > > @@ -4051,8 +4050,8 @@ static void show_cert_chain(HWND hwnd, struct hierarchy_data *data)
> > >                   */
> > >                  tvis.u.item.iImage = 2;
> > >              }
> > > -            else if (provSigner->pasCertChain[i - 1].pChainElement->TrustStatus.
> > > -             dwErrorStatus == 0)
> > > +            else if (i > 1 &&
> > > +                     provSigner->pasCertChain[i - 1].pChainElement->TrustStatus.dwErrorStatus == 0)
> >
> > What is this change for?
>
> there is no pasCertChain[0] for some reason, there is a similar check in show_dialog_for_selected_cert (same file, "selection" is checked for not being 0 and used as index for pasCertChain)

That's a bit different.  I wonder if there's a wintrust bug that leads
to this?  Any chance of opening a bug and attaching the cert that
produces the crash to it?
--Juan

cryptui: Fix a crash with certification path (resend)

[André Hentschel]

Am 06.10.2010 18:08, schrieb Juan Lang:
> > > > @@ -4051,8 +4050,8 @@ static void show_cert_chain(HWND hwnd, struct hierarchy_data *data)
> > > >                   */
> > > >                  tvis.u.item.iImage = 2;
> > > >              }
> > > > -            else if (provSigner->pasCertChain[i - 1].pChainElement->TrustStatus.
> > > > -             dwErrorStatus == 0)
> > > > +            else if (i > 1 &&
> > > > +                     provSigner->pasCertChain[i - 1].pChainElement->TrustStatus.dwErrorStatus == 0)
> > >
> > > What is this change for?
> >
> > there is no pasCertChain[0] for some reason, there is a similar check in show_dialog_for_selected_cert (same file, "selection" is checked for not being 0 and used as index for pasCertChain)
>
> That's a bit different.  I wonder if there's a wintrust bug that leads
> to this?  Any chance of opening a bug and attaching the cert that
> produces the crash to it?
> --Juan

sure, see http://bugs.winehq.org/show_bug.cgi?id=24649
(wasn't able to attach you...)

-- 

Best Regards, André Hentschel