Re: [PATCH] remove strange condition which might lead to crash

[Hans Leidekker]

On Thursday 10 January 2008 09:49:47 Marcus Meissner wrote:
> Coverity spotted "arg" as potentially NULL dereferenced
> and the originating condition looks broken to me.
>
> It should not really handle "delim", but just check arg.

Agreed, but there's another occurrence of this check in msvcrt_argvtos
which has been there all along. Did Coverity spot that one too?

 -Hans

[PATCH] remove strange condition which might lead to crash

[Marcus Meissner]

On Thu, Jan 10, 2008 at 10:12:22AM +0100, Hans Leidekker wrote:
> On Thursday 10 January 2008 09:49:47 Marcus Meissner wrote:
> > Coverity spotted "arg" as potentially NULL dereferenced
> > and the originating condition looks broken to me.
> >
> > It should not really handle "delim", but just check arg.
>
> Agreed, but there's another occurrence of this check in msvcrt_argvtos
> which has been there all along. Did Coverity spot that one too?

Yes, but way down the list. I am usually just looking at the latest
entries ;)

Ciao, Marcus