Re: wined3d: Avoid sizeof on structs with variable length arrays.
On 13 June 2012 10:41, Michael Stefaniuc <mstefani(a)redhat.de> wrote:
- object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*object)); + object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, FIELD_OFFSET(struct wined3d, adapters[1]));
That's not really a VLA, just a somewhat stupid array of size 1.
On 06/13/2012 12:56 PM, Henri Verbeet wrote:
On 13 June 2012 10:41, Michael Stefaniuc <mstefani(a)redhat.de> wrote:
- object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*object)); + object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, FIELD_OFFSET(struct wined3d, adapters[1]));
That's not really a VLA, just a somewhat stupid array of size 1. Uh... Any reason that field cannot be just struct wined3d_adapter adapter; ?
bye michael
On 13 June 2012 13:27, Michael Stefaniuc <mstefani(a)redhat.com> wrote:
Uh... Any reason that field cannot be just struct wined3d_adapter adapter; ?
Not really, but if we actually supported multihead we'd have multiple adapters and would need to change it back again.
participants (2)
-
Henri Verbeet -
Michael Stefaniuc