Re: [PATCH 3/3] user32: Don't rely on HMENU for showing popups

[Alexandre Julliard]

Andrew Eikum <aeikum(a)codeweavers.com> writes:
> The idea here is to push the conversions from HMENU to struct pointer
> up the call stack until eventually we are only converting to/from
> HMENUs near the client code border, so we don't depend on HMENU
> internally at all.

To do this right, you'd want to increase the refcount every time you get
a pointer. Otherwise the pointer could become invalid as soon as control
is transferred to the app through SendMessage (not that the current code
always gets it right, but when using handles the problem is much reduced).

-- 
Alexandre Julliard
julliard(a)winehq.org