Re: jscript: Change prototype of jsstr_alloc_buf and fix some error handling issues.

[Sebastian Lackner]

On 07.09.2016 12:57, Sebastian Lackner wrote:
> On 07.09.2016 10:50, Sebastian Lackner wrote:
> > From: Sebastian Lackner <sebastian(a)fds-team.de>
> >
> > Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de>
> > Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>
> >
> > v3: Fixed another false compiler warning in String_concat (missed during
> > previous review).
> > ---
> >
> > dlls/jscript/array.c    |  6 +++---
> >  dlls/jscript/date.c     | 22 +++++++++++-----------
> >  dlls/jscript/error.c    |  4 ++--
> >  dlls/jscript/function.c |  4 ++--
> >  dlls/jscript/global.c   | 22 +++++++++++-----------
> >  dlls/jscript/jsregexp.c |  4 ++--
> >  dlls/jscript/jsstr.c    | 17 +++++++++--------
> >  dlls/jscript/jsstr.h    |  6 +++---
> >  dlls/jscript/number.c   |  4 ++--
> >  dlls/jscript/object.c   |  4 ++--
> >  dlls/jscript/string.c   | 24 ++++++++++++------------
> >  11 files changed, 59 insertions(+), 58 deletions(-)
>
> Just to make sure that there is no confusion (because of the spoofed From: header),
> this version was sent by Jacek and not by me. Thanks for fixing this remaining issue.
>
> Regards,
> Sebastian

Sending to the wine-devel mailing list this time... ;)

jscript: Change prototype of jsstr_alloc_buf and fix some error handling issues.

[Jacek Caban]

On 07.09.2016 17:55, Sebastian Lackner wrote:
> On 07.09.2016 12:57, Sebastian Lackner wrote:
> > On 07.09.2016 10:50, Sebastian Lackner wrote:
> > > From: Sebastian Lackner <sebastian(a)fds-team.de>
> > >
> > > Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de>
> > > Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>
> > >
> > > v3: Fixed another false compiler warning in String_concat (missed during
> > > previous review).
> > > ---
> > >
> > > dlls/jscript/array.c    |  6 +++---
> > >  dlls/jscript/date.c     | 22 +++++++++++-----------
> > >  dlls/jscript/error.c    |  4 ++--
> > >  dlls/jscript/function.c |  4 ++--
> > >  dlls/jscript/global.c   | 22 +++++++++++-----------
> > >  dlls/jscript/jsregexp.c |  4 ++--
> > >  dlls/jscript/jsstr.c    | 17 +++++++++--------
> > >  dlls/jscript/jsstr.h    |  6 +++---
> > >  dlls/jscript/number.c   |  4 ++--
> > >  dlls/jscript/object.c   |  4 ++--
> > >  dlls/jscript/string.c   | 24 ++++++++++++------------
> > >  11 files changed, 59 insertions(+), 58 deletions(-)
> >
> > Just to make sure that there is no confusion (because of the spoofed From: header),
> > this version was sent by Jacek and not by me. Thanks for fixing this remaining issue.

Yeah, sorry about that.

Jacek