Folks, We now have an automated reviewer assignment bot in Gitlab, thanks to the work of Jeremy White, so I think it's time to retire the wine-devel patch tracker. From now on, please submit everything through merge requests; patches sent to wine-devel will no longer be applied. Some reminders about the new policies: - Adding a Signed-off-by header is no longer necessary. This is replaced by the Gitlab approval mechanism. - When a new MR is submitted, the bot will assign reviewers based on the MAINTAINERS file. If the bot got it wrong, or if you would like to request reviews from other people, feel free to modify the list of reviewers. - If you don't have permission to modify reviewers, you should request access to the Wine project. There should be a link for this on the main project page at https://gitlab.winehq.org/wine/wine - I won't merge a MR until all reviewers have approved it. If you are assigned as reviewer but are unable/unwilling to review that MR, please unassign yourself so that the MR isn't blocked waiting for your approval. - In general, approving your own MR is not necessary or useful. - As an exception to the above, if your MR contains commits authored by someone else, you are asked to explicitly approve it. The bot will assign you as an extra reviewer in that case. - Approval information is stored in git notes. You can fetch the refs/notes/commits head if you'd like to see that information in your local tree. - We now have a CI pipeline to make sure that all the commits of a MR compile cleanly. Later on, the pipeline will also run the tests. Make sure to check the pipeline results; a MR with a failed pipeline won't be merged. Questions? Comments? -- Alexandre Julliard julliard(a)winehq.org
Hey, Am Mo., 15. Aug. 2022 um 12:23 Uhr schrieb Alexandre Julliard <julliard(a)winehq.org>:
- Adding a Signed-off-by header is no longer necessary. This is replaced by the Gitlab approval mechanism.
- In general, approving your own MR is not necessary or useful.
So the replacement of Sign-Offs with self approving your MR is dropped now, if I understand correctly? (This was done for some time iirc) Thanks, Bernhard
Bernhard Kölbl <besentv(a)gmail.com> writes:
Hey,
Am Mo., 15. Aug. 2022 um 12:23 Uhr schrieb Alexandre Julliard <julliard(a)winehq.org>:
- Adding a Signed-off-by header is no longer necessary. This is replaced by the Gitlab approval mechanism.
- In general, approving your own MR is not necessary or useful.
So the replacement of Sign-Offs with self approving your MR is dropped now, if I understand correctly?
Yes. Self-approving your MR is only for the case where a commit is written by someone else. -- Alexandre Julliard julliard(a)winehq.org
On Mon, Aug 15, 2022, 12:23 Alexandre Julliard <julliard(a)winehq.org> wrote:
Folks,
We now have an automated reviewer assignment bot in Gitlab, thanks to the work of Jeremy White, so I think it's time to retire the wine-devel patch tracker. From now on, please submit everything through merge requests; patches sent to wine-devel will no longer be applied.
As the patch tracker has now been disabled, what is the future of the wine-gitlab list?
Gijs Vermeulen <gijsvrm(a)gmail.com> writes:
On Mon, Aug 15, 2022, 12:23 Alexandre Julliard <julliard(a)winehq.org> wrote:
Folks,
We now have an automated reviewer assignment bot in Gitlab, thanks to the work of Jeremy White, so I think it's time to retire the wine-devel patch tracker. From now on, please submit everything through merge requests; patches sent to wine-devel will no longer be applied.
As the patch tracker has now been disabled, what is the future of the wine-gitlab list?
The list will stay around, as long as people find it useful. -- Alexandre Julliard julliard(a)winehq.org
On 8/15/22 05:23, Alexandre Julliard wrote:
Folks,
We now have an automated reviewer assignment bot in Gitlab, thanks to the work of Jeremy White, so I think it's time to retire the wine-devel patch tracker. From now on, please submit everything through merge requests; patches sent to wine-devel will no longer be applied.
I didn't realize this meant retiring the patch tracker page. Is that necessary? Is there a chance it can be restored? It's faster and better UI than either gitlab web UI or command-line tools.
"Zebediah Figura (she/her)" <zfigura(a)codeweavers.com> writes:
On 8/15/22 05:23, Alexandre Julliard wrote:
Folks, We now have an automated reviewer assignment bot in Gitlab, thanks to the work of Jeremy White, so I think it's time to retire the wine-devel patch tracker. From now on, please submit everything through merge requests; patches sent to wine-devel will no longer be applied.
I didn't realize this meant retiring the patch tracker page. Is that necessary? Is there a chance it can be restored? It's faster and better UI than either gitlab web UI or command-line tools.
Yes, it's necessary, I'm not going to continue to maintain a parallel file-based database for the status of every patch, especially since it was really a hack put together with Elisp and duct tape. -- Alexandre Julliard julliard(a)winehq.org
On 8/16/22 15:04, Alexandre Julliard wrote:
"Zebediah Figura (she/her)" <zfigura(a)codeweavers.com> writes:
On 8/15/22 05:23, Alexandre Julliard wrote:
Folks, We now have an automated reviewer assignment bot in Gitlab, thanks to the work of Jeremy White, so I think it's time to retire the wine-devel patch tracker. From now on, please submit everything through merge requests; patches sent to wine-devel will no longer be applied.
I didn't realize this meant retiring the patch tracker page. Is that necessary? Is there a chance it can be restored? It's faster and better UI than either gitlab web UI or command-line tools.
Yes, it's necessary, I'm not going to continue to maintain a parallel file-based database for the status of every patch, especially since it was really a hack put together with Elisp and duct tape.
Okay. I figured it would be fine to keep around since there wasn't any need to manually update patch status, but I understand the need to remove old code.
participants (4)
-
Alexandre Julliard -
Bernhard Kölbl -
Gijs Vermeulen -
Zebediah Figura (she/her)