[PATCH] usp10: Don't increment variable both in the loop header and body (clang)
Signed-off-by: André Hentschel <nerv(a)dawncrow.de> --- dlls/usp10/shape.c | 1 - 1 file changed, 1 deletion(-) diff --git a/dlls/usp10/shape.c b/dlls/usp10/shape.c index 4031386..1927be0 100644 --- a/dlls/usp10/shape.c +++ b/dlls/usp10/shape.c @@ -1721,7 +1721,6 @@ static void ComposeConsonants(HDC hdc, WCHAR *pwOutChars, INT *pcChars, const Co break; } } - cWalk++; } } -- 2.7.4
On 3/27/18 11:46 AM, André Hentschel wrote:
Signed-off-by: André Hentschel <nerv(a)dawncrow.de> --- dlls/usp10/shape.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/dlls/usp10/shape.c b/dlls/usp10/shape.c index 4031386..1927be0 100644 --- a/dlls/usp10/shape.c +++ b/dlls/usp10/shape.c @@ -1721,7 +1721,6 @@ static void ComposeConsonants(HDC hdc, WCHAR *pwOutChars, INT *pcChars, const Co break; } } - cWalk++; } }
This patch is incorrect. We are checking for composing 2 glyph consonants so if we successfully compose we will use up 2 chars not just 1. -aric
participants (2)
-
André Hentschel -
Aric Stewart