Re: [2/5] resend ws2_32/tests: add tests for Inet_Ntop and inet_ntoa
Jeff Latimer wrote:
Note that Inet_Ntop is only available in Vista and Windows 2008. This patch removes the version testing. --- dlls/ws2_32/tests/sock.c | 67 ++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 67 insertions(+), 0 deletions(-)
------------------------------------------------------------------------
Two minor things: There is no need to to check the return value of GetModuleHandle as ws2_32 is already imported. Could you add a win_skip() somewhere so we know that some tests are skipped on some platforms? -- Cheers, Paul.
Paul Vriens wrote:
Two minor things: There is no need to to check the return value of GetModuleHandle as ws2_32 is already imported. Could you add a win_skip() somewhere so we know that some tests are skipped on some platforms? Done. Have resubmitted the set again.
participants (2)
-
Jeff Latimer -
Paul Vriens