Re: rpcdce.h fixes

[Ove Kaaven]

On Fri, 20 Dec 2002, Dimitrie O. Paun wrote:
> MinGW has them defined this way, and wxWindows likes them like this.
> Can someone please check that this matches the Windows headers?

It does, but it was more difficult to get things (rpcrt4 in particular) to
compile without warnings (or huge piles of typecasts) this way, so I
decided to just use LPSTR/LPWSTR instead in the rpc headers. Didn't think
it would cause problems.
> RPCRTAPI RPC_STATUS RPC_ENTRY                                                                                                                                        
> -  RpcStringFreeA(LPSTR* String);                                                                                                                                     
> +  RpcStringFreeA(unsigned char** String);                                                                                                                            
>  RPCRTAPI RPC_STATUS RPC_ENTRY                                                                                                                                        
> -  RpcStringFreeW(LPWSTR* String);                                                                                                                                    
> +  RpcStringFreeW(unsigned short** String);                                                                                                                           
>  #define RpcStringFree WINELIB_NAME_AW(RpcStringFree)

rpcdce.h fixes

[Dimitrie O. Paun]

On December 20, 2002 04:55 am, Ove Kaaven wrote:
> It does, but it was more difficult to get things (rpcrt4 in particular) to
> compile without warnings (or huge piles of typecasts) this way, so I
> decided to just use LPSTR/LPWSTR instead in the rpc headers. Didn't think
> it would cause problems.

It does, in C++ because of stronger typing than in C. We can do a conditional
thing #ifdef __WINE__ ... Alexandre?

-- 
Dimi.

rpcdce.h fixes

[Francois Gouget]

On Fri, 20 Dec 2002, Dimitrie O. Paun wrote:
> On December 20, 2002 04:55 am, Ove Kaaven wrote:
> > It does, but it was more difficult to get things (rpcrt4 in particular) to
> > compile without warnings (or huge piles of typecasts) this way, so I
> > decided to just use LPSTR/LPWSTR instead in the rpc headers. Didn't think
> > it would cause problems.
>
> It does, in C++ because of stronger typing than in C. We can do a conditional
> thing #ifdef __WINE__ ... Alexandre?

No. If it's supposed to be 'unsigned char*' then that's how it should be
and Wine's code just has to deal with it.



-- 
Francois Gouget         fgouget(a)free.fr        http://fgouget.free.fr/
 "Only wimps use tape backup: _real_ men just upload their important stuff on
       ftp, and let the rest of the world mirror it ;)" -- Linus Torvalds

rpcdce.h fixes

[Dimitrie O. Paun]

On December 20, 2002 12:21 pm, Francois Gouget wrote:
> No. If it's supposed to be 'unsigned char*' then that's how it should be
> and Wine's code just has to deal with it.

I am not the one maintaining the rpcdce code, so I don't really care.
Ove and Alexandre should determine what to do. I don't have time to
fix the warnings though, so someone else will have to run with this.

-- 
Dimi.