[PATCH] d3dx9: Simplify get_parameter_by_name().

[Matteo Bruni]

Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com>
---
 dlls/d3dx9_36/effect.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c
index fde87706739..81f16f6cbb3 100644
--- a/dlls/d3dx9_36/effect.c
+++ b/dlls/d3dx9_36/effect.c
@@ -918,7 +918,6 @@ struct d3dx_parameter *get_parameter_by_name(struct d3dx9_base_effect *base,
         return NULL;
     }
 
-    /* Pass / technique annotations are not in the parameters tree. */
     if (parameter->full_name)
     {
         name_len = strlen(name);
@@ -948,9 +947,11 @@ struct d3dx_parameter *get_parameter_by_name(struct d3dx9_base_effect *base,
         return NULL;
     }
 
+    /* Pass / technique annotations are not stored in the parameters tree,
+     * do a linear search. */
     count = parameter->member_count;
 
-    length = strcspn( name, "[.@" );
+    length = strcspn( name, "[." );
     part = name + length;
 
     for (i = 0; i < count; i++)
@@ -969,9 +970,6 @@ struct d3dx_parameter *get_parameter_by_name(struct d3dx9_base_effect *base,
                 case '.':
                     return get_parameter_by_name(base, temp_parameter, part);
 
-                case '@':
-                    return NULL;
-
                 case '[':
                     return get_parameter_element_by_name(base, temp_parameter, part);
 
-- 
2.19.2

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=47995

Your paranoid android.


=== debian9 (build log) ===

error: patch failed: dlls/d3dx9_36/effect.c:948
Task: Patch failed to apply

=== debian9 (build log) ===

error: patch failed: dlls/d3dx9_36/effect.c:948
Task: Patch failed to apply