Re: [PATCH 7/7] wined3d: Add support for patch constant signatures.
11 May
2017
11 May
'17
10:02 a.m.
On 10 May 2017 at 15:54, Józef Kucia <jkucia(a)codeweavers.com> wrote:
+ if (FAILED(hr = shader_signature_calculate_strings_length(&desc->input_signature, &len))) + return hr; + total = len; + if (FAILED(hr = shader_signature_calculate_strings_length(&desc->output_signature, &len))) + return hr; + total += len; + if (FAILED(hr = shader_signature_calculate_strings_length(&desc->patch_constant_signature, &len))) + return hr; + total += len; It's perhaps a fairly theoretical concern, but I think you can still make "total" overflow here.
3139
Age (days ago)
3139
Last active (days ago)
0 comments
1 participants
participants (1)
-
Henri Verbeet