Re: [PATCH 1/3] user32/tests: Added client-side raw input function tests (try 5 resend)

[André Hentschel]

Am 22.06.2011 06:26, schrieb Vincas Miliūnas:
> +    if (pDefRawInputProc && pGetRawInputBuffer && pGetRawInputData && pGetRawInputDeviceList &&
> +        pGetRawInputDeviceInfoA && pGetRawInputDeviceInfoW && pGetRegisteredRawInputDevices && pRegisterRawInputDevices)

You should avoid such a construct, move the check to test_functions that actually need these functions.
e.g. check for pGetRawInputBuffer only in test_get_raw_input_buffer
i didn't looked very close, but if the tests depend on each other there should be a comment.
the rest of that patch looks fine to me

-- 

Best Regards, André Hentschel

[PATCH 1/3] user32/tests: Added client-side raw input function tests (try 5 resend)

[Vitaliy Margolen]

On 06/26/2011 08:49 AM, André Hentschel wrote:
> Am 22.06.2011 06:26, schrieb Vincas Miliūnas:
> > +    if (pDefRawInputProc&&  pGetRawInputBuffer&&  pGetRawInputData&&  pGetRawInputDeviceList&&
> > +        pGetRawInputDeviceInfoA&&  pGetRawInputDeviceInfoW&&  pGetRegisteredRawInputDevices&&  pRegisterRawInputDevices)
>
> You should avoid such a construct, move the check to test_functions that actually need these functions.
> e.g. check for pGetRawInputBuffer only in test_get_raw_input_buffer
> i didn't looked very close, but if the tests depend on each other there should be a comment.
> the rest of that patch looks fine to me

I don't see a point here. It's all or nothing. There is only one raw input 
version, that is implemented starting from WinXP. All those functions are 
required.

Vitaliy.