Re: [PATCH 5/5] wined3d: Recognize another Radeon HD 4650 PCI device id.

[Henri Verbeet]

On 18 January 2017 at 21:35, Matteo Bruni <mbruni(a)codeweavers.com> wrote:
> Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com>
> ---
> For bug 34671, with thanks to winetaste(a)gmx.net for the relevant info.

This still doesn't make sense to me. In what cases does this make a
difference? Which of those do we care about?
> @@ -2018,8 +2019,8 @@ cards_amd_binary[] =
> -    {"HD 4670",                     CARD_AMD_RADEON_HD4600},    /* Radeon RV730 */
> -    {"HD 4650",                     CARD_AMD_RADEON_HD4600},    /* Radeon RV730 */
> +    {"HD 4670",                     CARD_AMD_RADEON_HD4650},    /* Radeon RV730 */
> +    {"HD 4650",                     CARD_AMD_RADEON_HD4650},    /* Radeon RV730 */
> This is arbitrary.

[PATCH 5/5] wined3d: Recognize another Radeon HD 4650 PCI device id.

[Matteo Bruni]

2017-01-19 12:32 GMT+01:00 Henri Verbeet <hverbeet(a)gmail.com>:
> On 18 January 2017 at 21:35, Matteo Bruni <mbruni(a)codeweavers.com> wrote:
> > Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com>
> > ---
> > For bug 34671, with thanks to winetaste(a)gmx.net for the relevant info.
>
> This still doesn't make sense to me. In what cases does this make a
> difference? Which of those do we care about?

Somehow I missed the patch attached to the bug and just read the last
comment there before writing this one...

The idea is that it should help for recognizing one more PCI device id
as a HD 4650 through the MESA_query_renderer extension. But right,
failing to find an entry in gpu_description_table[] it should just
fallback to the wined3d_guess_card() codepath and that should still
work (or at least there isn't any evidence otherwise), reporting a
different device ID belonging to the HD 4600 series is unlikely to
matter.
I guess in general we want to avoid adding more device IDs when
unnecessary so yeah, probably we don't want this patch...

[PATCH 5/5] wined3d: Recognize another Radeon HD 4650 PCI device id.

[Henri Verbeet]

On 19 January 2017 at 17:53, Matteo Bruni <matteo.mystral(a)gmail.com> wrote:
> I guess in general we want to avoid adding more device IDs when
> unnecessary so yeah, probably we don't want this patch...
> We'll probably have to think about how to handle multiple PCI IDs for
> the same GPU at some point, but I'd imagine something along the lines
> of just mapping 0x9498 to CARD_AMD_RADEON_HD4600 there.