Re: [PATCH 2/3] d3drm: Implement IDirect3DRMFrame*::GetScene. (v4)

[Henri Verbeet]

On 10 August 2016 at 17:41, Aaryaman Vasishta <jem456.vasishta(a)gmail.com> wrote:
> +    *scene = &frame->IDirect3DRMFrame3_iface;
> +
> +    while ((frame = frame->parent))
> +        *scene = &frame->IDirect3DRMFrame3_iface;
> +
> +    IDirect3DRMFrame3_AddRef(*scene);
> How about:

while (frame->parent)
        frame = frame->parent;

    IDirect3DRMFrame3_AddRef(*scene = &frame->IDirect3DRMFrame3_iface);

[PATCH 2/3] d3drm: Implement IDirect3DRMFrame*::GetScene. (v4)

[Aaryaman Vasishta]

On Fri, Aug 12, 2016 at 1:19 AM, Henri Verbeet <hverbeet(a)gmail.com> wrote:
> On 10 August 2016 at 17:41, Aaryaman Vasishta <jem456.vasishta(a)gmail.com>
> wrote:
> > +    *scene = &frame->IDirect3DRMFrame3_iface;
> > +
> > +    while ((frame = frame->parent))
> > +        *scene = &frame->IDirect3DRMFrame3_iface;
> > +
> > +    IDirect3DRMFrame3_AddRef(*scene);
> > How about:
>
> while (frame->parent)
>         frame = frame->parent;
>
> IDirect3DRMFrame3_AddRef(*scene = &frame->IDirect3DRMFrame3_iface);

Modified patch sent :) do take a look at 125479 as well. Thanks for the
review!

Cheers,
Aaryaman