RFC - Bug 22974 - "Shell folders" settings are reset after each wine update
Hello, I would like the latest patchset from bug 22974 reviewed. Bug 22974 - "Shell folders" settings are reset after each wine update https://bugs.winehq.org/show_bug.cgi?id=22974 v2 Patch 1/2 shell32: Move and split _SHCreateSymbolicLinks() https://bugs.winehq.org/attachment.cgi?id=65285 v2 Patch 2/2 shell32: Create symbolic links rather than directories for specific user shell folders https://bugs.winehq.org/attachment.cgi?id=65286 --- quote from bug 22974 comment 27 --- Patch 1/2: - Splits the _SHCreateSymbolicLinks() into folder type-specific functions, keeping the old logic intact. This way the different folders can be handled separately. - It also fixes some trailing whitespace in the moved code but that's negligible. Patch 2/2: - Adds a helper function that creates a single symbolic link at a time, for the folders we are interested in. - Calls the helper function where the old code did only create a directory. - Disables the removal of existing symlinks/directories, in the symlink creation functions. - Also says to not create the folder when looking up for its path for the symlink, to avoid an infinite loop. --- end of quote --- Regards. -- Olivier F. R. Dierick o.dierick(a)piezo-forte.be
participants (1)
-
Olivier F. R. Dierick