Re: Preliminary CD-Rom support on MacOS X #2

[Robert Shearman]

emmanuel maillard wrote:
> Changelog :
>     kernel/proces.c : Initialize darwin removable devices

I appreciate you splitting up your patches for easier review, but 
patches are meant to be independent atomic changes that improve the 
code. However, if Alexandre applied this patch alone then Wine wouldn't 
compile any more and this isn't acceptable.

-- 
Rob Shearman

Preliminary CD-Rom support on MacOS X #2

[emmanuel maillard]

Hi,

Thanks for the comment, i agree with it but i was thinking than  
keeping separated patches was better than (in this case)
merging  #2 + #3 + #5 in a big patch.

Any tricks are welcome.

Thanks

Emmanuel

Le 30 déc. 05 à 13:08, Robert Shearman a écrit :
> emmanuel maillard wrote:
> > Changelog :
> >     kernel/proces.c : Initialize darwin removable devices
>
> I appreciate you splitting up your patches for easier review, but  
> patches are meant to be independent atomic changes that improve the  
> code. However, if Alexandre applied this patch alone then Wine  
> wouldn't compile any more and this isn't acceptable.
>
> -- 
> Rob Shearman

[Darwine] Re: Preliminary CD-Rom support on MacOS X #2

[Pierre d'Herbemont]

emmanuel maillard wrote:
> On 30 déc. 05, at 13:08, Robert Shearman wrote:
> > I appreciate you splitting up your patches for easier review, but  
> > patches are meant to be independent atomic changes that improve  
> > the code. However, if Alexandre applied this patch alone then Wine  
> > wouldn't compile any more and this isn't acceptable.
> Any tricks are welcome.

Use git to create your separate patches (git format-patch) [1] from  
the small incremental changes you've committed to your own git  
repository.

Pierre.

[1] http://wiki.winehq.org/GitWine

[Darwine] Re: Preliminary CD-Rom support on MacOS X #2

[emmanuel maillard]

Thanks, i will take a look at git.

Emmanuel

Le 31 déc. 05 à 13:38, Pierre d'Herbemont a écrit :
> emmanuel maillard wrote:
> > On 30 déc. 05, at 13:08, Robert Shearman wrote:
> > > I appreciate you splitting up your patches for easier review, but  
> > > patches are meant to be independent atomic changes that improve  
> > > the code. However, if Alexandre applied this patch alone then  
> > > Wine wouldn't compile any more and this isn't acceptable.
> > Any tricks are welcome.
>
> Use git to create your separate patches (git format-patch) [1] from  
> the small incremental changes you've committed to your own git  
> repository.
>
> Pierre.
>
> [1] http://wiki.winehq.org/GitWine