Re: revised winmm GetDevCaps better pointer check patch
14 Jun
2004
14 Jun
'04
1:39 p.m.
Robert Reif <reif(a)earthlink.net> writes:
+/* Use the first version for strict compatibility with Microsoft */ +/* #define WINMM_IsBadWritePtr(x,y) IsBadWritePtr((x), (y)) */ +#define WINMM_IsBadWritePtr(x,y) ((x)==NULL)
This is very confusing, if we don't check the pointer we shouldn't have a macro that looks like we do. The proper way is to add exception handlers in functions where an app explicitly relies on the pointer check, and not add checks otherwise; using the IsBad*Ptr functions is always wrong since they are not thread-safe. -- Alexandre Julliard julliard(a)winehq.org
7851
Age (days ago)
7851
Last active (days ago)
0 comments
1 participants
participants (1)
-
Alexandre Julliard