Re: [2/2 v4 resend] winex11.drv: Implement FlashWindowEx.

[André Hentschel]

Am 03.10.2015 um 05:39 schrieb Jactry Zeng:
> Superseded patch 114739.
>
> ChangeLog:
> v4:
> - Rename driver entry to FlashWindowEx;
> - Put FlashWindowEx/pFlashWindowEx in right place;
> - Add CDECL for X11DRV_FlashWindowEx.
> v3:
> - Use x11drv_atom instead of XInternAtom;
> - Only do XSendEvent() when data->mapped is true.
> v2:
> - Use _NET_WM_STATE_DEMANDS_ATTENTION instead of Urgency.

Hi,
I haven't looked closer, but normally the implementation should be in the Ex-function and the non-Ex-function should call the Ex-function.
In this patch you do Ex->non-Ex->Ex which looks strange.

[2/2 v4 resend] winex11.drv: Implement FlashWindowEx.

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Am 2015-10-03 um 14:56 schrieb André Hentschel:
> I haven't looked closer, but normally the implementation should be
> in the Ex-function and the non-Ex-function should call the
> Ex-function. In this patch you do Ex->non-Ex->Ex which looks
> strange.
> I don't have the mail available, but Ken suggested that the Ex->non-ex
> path in user32 is OK for now, but that he cared about having the right
> driver entry point.

(https://www.winehq.org/pipermail/wine-devel/2015-September/109474.html)
. Of course the question now is how much Alexandre cares about this.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJWEPb0AAoJEN0/YqbEcdMw5ZAP/2ILPRhalB/S0Qgy2DC2p12P
lrUwcaA43wjSI7nCXMVJGcmExHS4YYcyA5gz/NM2ip8dkaOwpSOyhOLOFb9f/fyG
6MPw5e5gl8apDvm1AFyU7GayVIzMxpleDcRLCUs8hrqBY559c7AdJ6B/ZI9n2yDn
E0vF9EfIs+hY228anOiuia6fCv2eGiwGcvuv+cfxLL7G55K9bojwqPjKMAyZez1z
mHqSapK0WwNx78moO5P0LRU12sZ9uAR2ukCUoI4/IW0beWMWG+5KYyDI2COlTuD/
BscsvWL5YMtpeUzMB7115l80aGU2uS7LKFq285O+1uGx5g/aqKzJC50SszCebv2u
O8MQmIcMPAPxyCwcS1HRv5Fq06q9Rp8pCBdi8lc30xdqe7tj2mYTDqbhAMQq/yxY
q8V6Qj6MqF5pQxatP3ql0Jvau17PYc7mKj8S4rjYN+h7tyVti9OTQCD1+t9VIyx2
zIfDSO8oR8ZDpHCB1qu2thk8e4Sh+LBUoIBpnLfJGRSkGKtcysoB3wDf8jTtwaVD
0kgnekz9HKzoF8IkF8+jYhUtCqkyWdNgc7uirwKkxOFp+ghbP2NXMOVRvb/6PIss
qayBTD+Ys8caXNDJn3dQ/MXnJgbtfWwYk+3H+XgukiA+HTB9u4V8ftv18Yx33OVe
dj76072Lo0Umxl3r8SKI
=6OnW
-----END PGP SIGNATURE-----