Re: iphlpapi: Implement GetUnicastIpAddressTable (try 2)

[Hans Leidekker]

> +DWORD WINAPI GetUnicastIpAddressTable(ADDRESS_FAMILY family, MIB_UNICASTIPADDRESS_TABLE **table)
> +{
> +    IP_ADAPTER_ADDRESSES *aa, *ptr;
> +    MIB_UNICASTIPADDRESS_TABLE *data;
> +    DWORD ret, count = 0;
> +    ULONG size;
> +
> +    TRACE("%u, %p\n", family, table);
> +
> +    if (!table || (family != WS_AF_INET && family != WS_AF_INET6 && family != WS_AF_UNSPEC))
> +        return ERROR_INVALID_PARAMETER;
> +
> +    ret = GetAdaptersAddresses(family, 0, NULL, NULL, &size);

You should pass GAA_FLAG_SKIP_* flags here to exclude any data that will not be used.

iphlpapi: Implement GetUnicastIpAddressTable (try 2)

[Bruno Jesus]

On Monday, March 27, 2017, Hans Leidekker <hans(a)codeweavers.com> wrote:
> > +DWORD WINAPI GetUnicastIpAddressTable(ADDRESS_FAMILY family,
> > MIB_UNICASTIPADDRESS_TABLE **table)
> > +{
> > +    IP_ADAPTER_ADDRESSES *aa, *ptr;
> > +    MIB_UNICASTIPADDRESS_TABLE *data;
> > +    DWORD ret, count = 0;
> > +    ULONG size;
> > +
> > +    TRACE("%u, %p\n", family, table);
> > +
> > +    if (!table || (family != WS_AF_INET && family != WS_AF_INET6 &&
> > family != WS_AF_UNSPEC))
> > +        return ERROR_INVALID_PARAMETER;
> > +
> > +    ret = GetAdaptersAddresses(family, 0, NULL, NULL, &size);
>
> You should pass GAA_FLAG_SKIP_* flags here to exclude any data that will
> not be used.

Thanks for the review, I'll leave that to André ;-)