[PATCH 1/5] wined3d: Enable the multi-threaded command stream by default.

[Henri Verbeet]

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>
---
 dlls/wined3d/wined3d_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/wined3d/wined3d_main.c b/dlls/wined3d/wined3d_main.c
index 28a34a7..6c23d0b 100644
--- a/dlls/wined3d/wined3d_main.c
+++ b/dlls/wined3d/wined3d_main.c
@@ -72,7 +72,7 @@ static CRITICAL_SECTION wined3d_wndproc_cs = {&wined3d_wndproc_cs_debug, -1, 0,
  * where appropriate. */
 struct wined3d_settings wined3d_settings =
 {
-    FALSE,          /* No multithreaded CS by default. */
+    TRUE,           /* Multithreaded CS by default. */
     FALSE,          /* explicit_gl_version */
     MAKEDWORD_VERSION(1, 0), /* Default to legacy OpenGL */
     TRUE,           /* Use of GLSL enabled by default */
-- 
2.1.4

[Alexandre Julliard]

Henri Verbeet <hverbeet(a)codeweavers.com> writes:
> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>
> ---
>  dlls/wined3d/wined3d_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This is breaking ddraw here:

../../../tools/runtest -q -P wine -T ../../.. -M ddraw.dll -p ddraw_test.exe.so ddraw1 && touch ddraw1.ok
failed to create drawable
0036:err:d3d:context_set_gl_context Failed to set pixel format 5 on device context 0x160044.
failed to create drawable
0039:err:d3d:context_create Failed to set pixel format 5 on device context 0x50045.
X Error of failed request:  GLXBadWindow
  Major opcode of failed request:  155 (GLX)
  Minor opcode of failed request:  32 (X_GLXDestroyWindow)
  Serial number of failed request:  1197
  Current serial number in output stream:  1208
Makefile:226: recipe for target 'ddraw1.ok' failed

-- 
Alexandre Julliard
julliard(a)winehq.org

[Henri Verbeet]

On 30 January 2018 at 23:53, Alexandre Julliard <julliard(a)winehq.org> wrote:
> This is breaking ddraw here:
>
> ../../../tools/runtest -q -P wine -T ../../.. -M ddraw.dll -p ddraw_test.exe.so ddraw1 && touch ddraw1.ok
> failed to create drawable
> 0036:err:d3d:context_set_gl_context Failed to set pixel format 5 on device context 0x160044.
> failed to create drawable
> 0039:err:d3d:context_create Failed to set pixel format 5 on device context 0x50045.
> X Error of failed request:  GLXBadWindow
>   Major opcode of failed request:  155 (GLX)
>   Minor opcode of failed request:  32 (X_GLXDestroyWindow)
>   Serial number of failed request:  1197
>   Current serial number in output stream:  1208
> Makefile:226: recipe for target 'ddraw1.ok' failed

Oh right, that's bug 40767. I had reverted
c89dc58deb9ba74d8dcd7faf7012203cff0724a0 locally while working on
upstreaming csmt, in the idle hope that it would be fixed by the time
I was done with that, and then promptly forgot about it.