Re: [3/4] WineX11: Ignore the alpha if all pixels are 0x00

[Juan Lang]

Hi Stefan, a few minor nits:

+     * one pixel has alpha != 0x00, and the mask ignored as described in the

Do you mean, "the mask is ignored...", or "the AND mask is ignored..." ?

+     * written at 8 / 16 bpp times do not knwow about the 32 bit alpha, so

s/knwow/know/

+        for (y = 0; y < ymax; ++y)
+        {
+            xor_ptr = xor_bits + (y * xor_width_bytes);
+            for (x = 0; x < xmax; ++x)
+            {
+                if(xor_ptr[3] != 0x00) {
+                    alpha_zero = FALSE;
+                    break;

For the first for loop, you probably want something like (for y = 0;
alpha_zero && y < ymax...
Also, the whitespace around the if is a bit funny.
--Juan

[3/4] WineX11: Ignore the alpha if all pixels are 0x00

[Stefan Dösinger]

Am Donnerstag, 13. Dezember 2007 05:18:29 schrieb Juan Lang:
> Hi Stefan, a few minor nits:
>
> For the first for loop, you probably want something like (for y = 0;
> alpha_zero && y < ymax...
> Also, the whitespace around the if is a bit funny.
> Ah right, it won't drop out of the outer loop of course :-). Thanks for the 
> hint