Re: [PATCH] comctl32/tests: Add tests for mouse right-click in a treeview control

[Alexandre Julliard]

Nikolay Sivov <nsivov(a)codeweavers.com> writes:
> From: Hugh McMaster <hugh.mcmaster(a)outlook.com>
>
> Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com>
> Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com>
> ---
>  dlls/comctl32/tests/treeview.c | 77 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 77 insertions(+)

This fails here:

../../../tools/runtest -q -P wine -T ../../.. -M comctl32.dll -p comctl32_test.exe.so treeview && touch treeview.ok
treeview.c:2653: Test failed: right click sequence: the msg sequence is not complete: expected 0000 - actual 000f
treeview.c:2654: Test failed: parent right click sequence: the msg sequence is not complete: expected 0000 - actual 004e
Makefile:968: recipe for target 'treeview.ok' failed
make[1]: *** [treeview.ok] Error 2

-- 
Alexandre Julliard
julliard(a)winehq.org

[PATCH] comctl32/tests: Add tests for mouse right-click in a treeview control

[Hugh McMaster]

On Thursday, 4 May 2017 7:00 AM, Alexandre Julliard wrote:
> This fails here:
>
> ../../../tools/runtest -q -P wine -T ../../.. -M comctl32.dll -p comctl32_test.exe.so treeview && touch treeview.ok
> treeview.c:2653: Test failed: right click sequence: the msg sequence is not complete: expected 0000 - actual 000f
> treeview.c:2654: Test failed: parent right click sequence: the msg sequence is not complete: expected 0000 - actual 004e
> Makefile:968: recipe for target 'treeview.ok' failed
> make[1]: *** [treeview.ok] Error 2

So I looked into why these tests are failing on Wine now, when they didn't back in mid-March.

There are two ways to fix this:

1. Add an additional flush_events() call before ClientToScreen(hMainWnd, &pt); or
2. Call ShowWindow(hMainWnd, SW_HIDE) before returning from test_focus().

The parent window remains visible after test_focus(), although I don't know whether this is intentional. Nikolay?
If we do choose option (2), we may need to adjust some of the other tests to either show or hide
the parent window as necessary. This may be a better option though.

Any thoughts?

--
Hugh McMaster