Re: [PATCH 1/3] riched20: Use codepage in ME_ToUnicode.

[Phil Krylov]

Hello,
> -        ME_EndToUnicode(unicode, wszText);
> +        unicode ? ME_EndToUnicode(1200, wszText) : ME_EndToUnicode(CP_ACP, wszText);

Personally I dislike this stuff in C code. Especially when you could
make it shorter:

ME_EndToUnicode(unicode ? 1200 : CP_ACP, wszText)

-- Ph.

[PATCH 1/3] riched20: Use codepage in ME_ToUnicode.

[Jactry Zeng]

Hi Phil,

2013/9/4 Phil Krylov <phil(a)newstar.rinet.ru>
> Hello,
> > -        ME_EndToUnicode(unicode, wszText);
> > +        unicode ? ME_EndToUnicode(1200, wszText) :

ME_EndToUnicode(CP_ACP, wszText);
> Personally I dislike this stuff in C code. Especially when you could
> make it shorter:
>
> ME_EndToUnicode(unicode ? 1200 : CP_ACP, wszText)

Thanks for your review and comment, I will try it again.
> -- Ph.

--
Regards,
Jactry Zeng