Re: RFC: wintab32: Qt applications crash after WTOpen
On Wed, Oct 24, 2018 at 11:01 AM Bernhard Übelacker <bernhardu(a)mailbox.org> wrote:
Hello Alex, thank you for getting that bug fixed.
There is just one thing that I remember now, that led me explore the complicated way. Now every user without such hardware gets such a message in the terminal:
benutzer(a)debian:~/.wine/drive_c/test$ wine digitalclock.exe 0009:err:wintab32:LoadTablet LoadTabletInfo(0x10046) failed
I am not sure if thats an issue.
If I understand correctly, practically every application that depends on the latest version of Qt is going to trigger this error message. The message (line 168 of dlls/wintab32/context.c) should probably just be deleted. Would you like to send the patch for that? -Alex
On Wed, Oct 24, 2018 at 11:24 AM Alex Henrie <alexhenrie24(a)gmail.com> wrote:
On Wed, Oct 24, 2018 at 11:01 AM Bernhard Übelacker <bernhardu(a)mailbox.org> wrote:
Hello Alex, thank you for getting that bug fixed.
There is just one thing that I remember now, that led me explore the complicated way. Now every user without such hardware gets such a message in the terminal:
benutzer(a)debian:~/.wine/drive_c/test$ wine digitalclock.exe 0009:err:wintab32:LoadTablet LoadTabletInfo(0x10046) failed
I am not sure if thats an issue.
If I understand correctly, practically every application that depends on the latest version of Qt is going to trigger this error message. The message (line 168 of dlls/wintab32/context.c) should probably just be deleted. Would you like to send the patch for that?
Actually, on second thought, I think it's better to move the "Initializing the tablet" message into the if block and downgrade the "LoadTabletInfo failed" message in the else block from ERR to TRACE. I'll send a patch tonight if you don't beat me to it. -Alex
Am 24.10.2018 um 19:30 schrieb Alex Henrie:
On Wed, Oct 24, 2018 at 11:24 AM Alex Henrie <alexhenrie24(a)gmail.com> wrote:
On Wed, Oct 24, 2018 at 11:01 AM Bernhard Übelacker <bernhardu(a)mailbox.org> wrote:
Hello Alex, thank you for getting that bug fixed.
There is just one thing that I remember now, that led me explore the complicated way. Now every user without such hardware gets such a message in the terminal:
benutzer(a)debian:~/.wine/drive_c/test$ wine digitalclock.exe 0009:err:wintab32:LoadTablet LoadTabletInfo(0x10046) failed
I am not sure if thats an issue.
If I understand correctly, practically every application that depends on the latest version of Qt is going to trigger this error message. The message (line 168 of dlls/wintab32/context.c) should probably just be deleted. Would you like to send the patch for that?
Actually, on second thought, I think it's better to move the "Initializing the tablet" message into the if block and downgrade the "LoadTabletInfo failed" message in the else block from ERR to TRACE. I'll send a patch tonight if you don't beat me to it.
Yes, sorry I first thought every application would print this message, but that are just these loading wintab32. Just one other question, do you see any value in the tests from my first email? Thanks for taking your time. Kind regards, Bernhard
On Wed, Oct 24, 2018 at 2:04 PM Bernhard Übelacker <bernhardu(a)mailbox.org> wrote:
Just one other question, do you see any value in the tests from my first email?
As currently written, I think they're a good start but not ready for inclusion in Wine. It would be great to have a test that shows that WTInfo returns certain default values if the computer is not a tablet, but I don't know how to write that test properly without more information about what WTInfo does when the computer is indeed a tablet. -Alex
participants (2)
-
Alex Henrie -
Bernhard Übelacker