Re: MSI: Extract file directly to their target location

[Thomas Weidenmueller]

Mike McCormack wrote:
> +        /*
> +         * FIXME: 0 is a valid return from CreateFile
> +         *        but an invalid handle for the cabinet API
> +         */

NULL cannot be a valid file handle. The very first handle in the handle
table has the value 0x4. Apart from that, the PSDK doesn't mention it
can ever return NULL.

- Thomas

MSI: Extract file directly to their target location

[Thomas Weidenmueller]

Thomas Weidenmueller wrote:
> Mike McCormack wrote:
> > +        /*
> > +         * FIXME: 0 is a valid return from CreateFile
> > +         *        but an invalid handle for the cabinet API
> > +         */
>
> NULL cannot be a valid file handle. The very first handle in the handle
> table has the value 0x4. Apart from that, the PSDK doesn't mention it
> can ever return NULL.
>
> - Thomas

Never mind, i noticed you corrected that in the following patch

- Thomas

MSI: Extract file directly to their target location

[Mike McCormack]

Thomas Weidenmueller wrote:
> Never mind, i noticed you corrected that in the following patch

I should have merged the two patches together, but I'm getting used to 
using git, and haven't figured out how to do that easily as yet.

Mike

MSI: Extract file directly to their target location

[Michael Stefaniuc]

Mike McCormack wrote:
> Thomas Weidenmueller wrote:
> > Never mind, i noticed you corrected that in the following patch
>
> I should have merged the two patches together, but I'm getting used to 
> using git, and haven't figured out how to do that easily as yet.

No clue how to do that with git but combinediff from patchutils can do that.

bye
	michael
-- 
Michael Stefaniuc               Tel.: [phone]
Sr. Network Engineer            Fax.: [phone]
Red Hat GmbH                    Email: mstefani(a)redhat.com
Hauptstaetterstr. 58            http://www.redhat.de/
D-70178 Stuttgart