[PATCH v2 1/2] kernel32/tests: Test stack overflow by DefineDosDeviceW().

[Xu Wei]

Signed-off-by: Xu Wei <xuwei(a)uniontech.com>
---
 dlls/kernel32/tests/volume.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/dlls/kernel32/tests/volume.c b/dlls/kernel32/tests/volume.c
index cb35de6add1..f8e0fdc0582 100644
--- a/dlls/kernel32/tests/volume.c
+++ b/dlls/kernel32/tests/volume.c
@@ -185,6 +185,11 @@ static void test_dos_devices(void)
     ret = QueryDosDeviceA( drivestr, buf, sizeof(buf) );
     ok(!ret, "expected failure\n");
     ok(GetLastError() == ERROR_FILE_NOT_FOUND, "got error %u\n", GetLastError());
+
+    ret = DefineDosDeviceA(DDD_RAW_TARGET_PATH, "{00000001-0000-0000-0000-5E3B001A0145}", "\\Device\\{00000001-0000-0000-0000-5E3B001A0145}");
+    ok(ret, "failed to define drive %s, error %u\n", drivestr, GetLastError());
+
+    
 }
 
 static void test_FindFirstVolume(void)
-- 
2.20.1

[PATCH v2 2/2] kernelbase:fix stack overflow by DefineDosDeviceW().

[Xu Wei]

Signed-off-by: Xu Wei <xuwei(a)uniontech.com>
---
 dlls/kernelbase/volume.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/kernelbase/volume.c b/dlls/kernelbase/volume.c
index d513dda1f9d..7988d4fa193 100644
--- a/dlls/kernelbase/volume.c
+++ b/dlls/kernelbase/volume.c
@@ -384,7 +384,7 @@ err_ret:
  */
 BOOL WINAPI DECLSPEC_HOTPATCH DefineDosDeviceW( DWORD flags, const WCHAR *device, const WCHAR *target )
 {
-    WCHAR link_name[15] = L"\\DosDevices\\";
+    WCHAR link_name[MAX_PATH] = L"\\DosDevices\\";
     UNICODE_STRING nt_name, nt_target;
     OBJECT_ATTRIBUTES attr;
     NTSTATUS status;
-- 
2.20.1