Re: [PATCH] msvcrt: Fix strcpy implementation so it works on overlapping buffers

[Ken Thomases]

On Aug 5, 2017, at 10:43 AM, Piotr Caban <piotr(a)codeweavers.com> wrote:
> +char* CDECL MSVCRT_strcpy(char *dst, const char *src)
> +{
> +    char *ret = dst;
> +
> +    while(1) {
> +        *dst = *src;
> +        if (!*src) break;
> +        src++;
> +        *dst++;

What's the dereference for?
> +    }
> +
> +    return ret;
> +}

-Ken

[PATCH] msvcrt: Fix strcpy implementation so it works on overlapping buffers

[Piotr Caban]

On 08/05/17 18:21, Ken Thomases wrote:
> On Aug 5, 2017, at 10:43 AM, Piotr Caban <piotr(a)codeweavers.com> wrote:
> > +char* CDECL MSVCRT_strcpy(char *dst, const char *src)
> > +{
> > +    char *ret = dst;
> > +
> > +    while(1) {
> > +        *dst = *src;
> > +        if (!*src) break;
> > +        src++;
> > +        *dst++;
>
> What's the dereference for?
> My bad, thanks for spotting it. I've sent a fixed version.

Thanks,
Piotr