Re: testbot/lib: If we cannot open the log file, then log to stderr.
Hi François, While your are at it. I would like to do a suggestion. Indeed that would be great to be able to download some files along with the test. Typically for me avi files and dlls (or .drv) would be great ! :D Thanks Christian, 2012/10/15 Francois Gouget <fgouget(a)codeweavers.com>
--- testbot/lib/WineTestBot/Log.pm | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/testbot/lib/WineTestBot/Log.pm b/testbot/lib/WineTestBot/Log.pm index 6883968..7de6dcb 100644 --- a/testbot/lib/WineTestBot/Log.pm +++ b/testbot/lib/WineTestBot/Log.pm @@ -38,20 +38,18 @@ sub LogMsg(@) if (!defined $logfile) { my $oldumask = umask(002); - if (open($logfile, ">>", "$LogDir/log")) - { - # Flush after each print - my $tmp=select($logfile); - $| = 1; - select($tmp); - } - else + if (!open($logfile, ">>", "$LogDir/log")) { require File::Basename; print STDERR File::Basename::basename($0), ":warning: could not open '$LogDir/log' for writing: $!\n"; - $logfile = undef; + open($logfile, ">>&=", 2); } umask($oldumask); + + # Flush after each print + my $tmp=select($logfile); + $| = 1; + select($tmp); } print $logfile scalar localtime, " ", @_ if ($logfile); } -- 1.7.10.4
Christian Costa <titan.costa(a)gmail.com> wrote:
Indeed that would be great to be able to download some files along with the test. Typically for me avi files and dlls (or .drv) would be great ! :D
Just do what other tests do: embed all the required data into the test: be it a PE executable, TIFF/GIF/PNG/etc image, or even a RIFF/AVI file. That way the tests don't depend on any external files, or abilities in the tested environment to download them. -- Dmitry.
Le 15/10/2012 18:07, Dmitry Timoshkov a écrit :
Christian Costa <titan.costa(a)gmail.com> wrote:
Indeed that would be great to be able to download some files along with the test. Typically for me avi files and dlls (or .drv) would be great ! :D Just do what other tests do: embed all the required data into the test: be it a PE executable, TIFF/GIF/PNG/etc image, or even a RIFF/AVI file. That way the tests don't depend on any external files, or abilities in the tested environment to download them.
It seems a bit complicated for a test I will run only once and not intended to be part of the test suite.
On Mon, Oct 15, 2012 at 12:14 PM, Christian Costa <titan.costa(a)gmail.com> wrote:
Le 15/10/2012 18:07, Dmitry Timoshkov a écrit :
Christian Costa <titan.costa(a)gmail.com> wrote:
Indeed that would be great to be able to download some files along with the test. Typically for me avi files and dlls (or .drv) would be great ! :D
Just do what other tests do: embed all the required data into the test: be it a PE executable, TIFF/GIF/PNG/etc image, or even a RIFF/AVI file. That way the tests don't depend on any external files, or abilities in the tested environment to download them.
It seems a bit complicated for a test I will run only once and not intended to be part of the test suite.
You could use a self extracting exe. -- -Austin
Le 15/10/2012 21:16, Austin English a écrit :
On Mon, Oct 15, 2012 at 12:14 PM, Christian Costa <titan.costa(a)gmail.com> wrote:
Le 15/10/2012 18:07, Dmitry Timoshkov a écrit :
Christian Costa <titan.costa(a)gmail.com> wrote:
Indeed that would be great to be able to download some files along with the test. Typically for me avi files and dlls (or .drv) would be great ! :D Just do what other tests do: embed all the required data into the test: be it a PE executable, TIFF/GIF/PNG/etc image, or even a RIFF/AVI file. That way the tests don't depend on any external files, or abilities in the tested environment to download them.
It seems a bit complicated for a test I will run only once and not intended to be part of the test suite. You could use a self extracting exe.
Why not if I can make it run the test after the extraction. That said why not improving test bot download extra files? Is there a specific reason for that?
On Mon, Oct 15, 2012 at 12:28 PM, Christian Costa <titan.costa(a)gmail.com> wrote:
Le 15/10/2012 21:16, Austin English a écrit :
On Mon, Oct 15, 2012 at 12:14 PM, Christian Costa <titan.costa(a)gmail.com> wrote:
Le 15/10/2012 18:07, Dmitry Timoshkov a écrit :
Christian Costa <titan.costa(a)gmail.com> wrote:
Indeed that would be great to be able to download some files along with the test. Typically for me avi files and dlls (or .drv) would be great ! :D
Just do what other tests do: embed all the required data into the test: be it a PE executable, TIFF/GIF/PNG/etc image, or even a RIFF/AVI file. That way the tests don't depend on any external files, or abilities in the tested environment to download them.
It seems a bit complicated for a test I will run only once and not intended to be part of the test suite.
You could use a self extracting exe.
Why not if I can make it run the test after the extraction. That said why not improving test bot download extra files? Is there a specific reason for that?
I'm not against improving the testbot, it was just a suggestion. -- -Austin
Le 15/10/2012 21:29, Austin English a écrit :
On Mon, Oct 15, 2012 at 12:28 PM, Christian Costa <titan.costa(a)gmail.com> wrote:
Le 15/10/2012 21:16, Austin English a écrit :
On Mon, Oct 15, 2012 at 12:14 PM, Christian Costa <titan.costa(a)gmail.com> wrote:
Le 15/10/2012 18:07, Dmitry Timoshkov a écrit :
Christian Costa <titan.costa(a)gmail.com> wrote:
Indeed that would be great to be able to download some files along with the test. Typically for me avi files and dlls (or .drv) would be great ! :D Just do what other tests do: embed all the required data into the test: be it a PE executable, TIFF/GIF/PNG/etc image, or even a RIFF/AVI file. That way the tests don't depend on any external files, or abilities in the tested environment to download them.
It seems a bit complicated for a test I will run only once and not intended to be part of the test suite. You could use a self extracting exe.
Why not if I can make it run the test after the extraction. That said why not improving test bot download extra files? Is there a specific reason for that? I'm not against improving the testbot, it was just a suggestion.
It's a good one.I will file a bug in bugzilla for the test bot and try your suggestion. Do you know any simple tool that enables to do that?
On Mon, Oct 15, 2012 at 12:45 PM, Christian Costa <titan.costa(a)gmail.com> wrote:
Le 15/10/2012 21:29, Austin English a écrit :
On Mon, Oct 15, 2012 at 12:28 PM, Christian Costa <titan.costa(a)gmail.com> wrote:
Le 15/10/2012 21:16, Austin English a écrit :
On Mon, Oct 15, 2012 at 12:14 PM, Christian Costa <titan.costa(a)gmail.com> wrote:
Le 15/10/2012 18:07, Dmitry Timoshkov a écrit :
Christian Costa <titan.costa(a)gmail.com> wrote:
> Indeed that would be great to be able to download some files along > with > the > test. > Typically for me avi files and dlls (or .drv) would be great ! :D
Just do what other tests do: embed all the required data into the test: be it a PE executable, TIFF/GIF/PNG/etc image, or even a RIFF/AVI file. That way the tests don't depend on any external files, or abilities in the tested environment to download them.
It seems a bit complicated for a test I will run only once and not intended to be part of the test suite.
You could use a self extracting exe.
Why not if I can make it run the test after the extraction. That said why not improving test bot download extra files? Is there a specific reason for that?
I'm not against improving the testbot, it was just a suggestion.
It's a good one.I will file a bug in bugzilla for the test bot and try your suggestion. Do you know any simple tool that enables to do that?
7-zip, look into its -sfx option. -- -Austin
On Mon, 15 Oct 2012, Christian Costa wrote: [...]
Why not if I can make it run the test after the extraction. That said why not improving test bot download extra files? Is there a specific reason for that? I'm not against improving the testbot, it was just a suggestion.
It's a good one.I will file a bug in bugzilla for the test bot and try your suggestion. Do you know any simple tool that enables to do that?
If the sfx approach can be made to work without changes to WineTestBot then it may be worth documenting somewhere on the Wiki. Otherwise I'd rather modify WineestBot to accept .zip files in addition to .exe ones. This would cause the zip file to be extracted in a temporary directory, maybe not allowing subdirectories, and the one .exe file it contains would be run. I think that process would be more intuitive. If we need to allow more than one exe, letting the user specify the command to run should resolve any ambiguities. -- Francois Gouget <fgouget(a)codeweavers.com>
2012/10/16 Francois Gouget <fgouget(a)codeweavers.com>
On Mon, 15 Oct 2012, Christian Costa wrote: [...]
Why not if I can make it run the test after the extraction. That said why not improving test bot download extra files? Is there a specific reason for that? I'm not against improving the testbot, it was just a suggestion.
It's a good one.I will file a bug in bugzilla for the test bot and try your suggestion. Do you know any simple tool that enables to do that?
If the sfx approach can be made to work without changes to WineTestBot then it may be worth documenting somewhere on the Wiki.
Otherwise I'd rather modify WineestBot to accept .zip files in addition to .exe ones. This would cause the zip file to be extracted in a temporary directory, maybe not allowing subdirectories, and the one .exe file it contains would be run. I think that process would be more intuitive.
If we need to allow more than one exe, letting the user specify the command to run should resolve any ambiguities.
That would be perfect!
Christian Costa <titan.costa(a)gmail.com> wrote:
Indeed that would be great to be able to download some files along with the test. Typically for me avi files and dlls (or .drv) would be great ! :D Just do what other tests do: embed all the required data into the test: be it a PE executable, TIFF/GIF/PNG/etc image, or even a RIFF/AVI file. That way the tests don't depend on any external files, or abilities in the tested environment to download them.
It seems a bit complicated for a test I will run only once and not intended to be part of the test suite.
Another approach is how gdi32/tests/font.c embeds wine_test.ttf font file using RCDATA resource. That just adds a simple extraction helper and is pretty trivial and universal for any kind of data file. -- Dmitry.
participants (4)
-
Austin English -
Christian Costa -
Dmitry Timoshkov -
Francois Gouget