Re: [try 3] [PATCH 03/12] comctl32: Implement Add, ReplaceIcon, GetImageCount, SetImageCount in IImageList

[Alexandre Julliard]

Owen Rudge <orudge(a)codeweavers.com> writes:
> @@ -2985,15 +2985,37 @@ static ULONG WINAPI ImageListImpl_Release(IImageList *iface)
>  static HRESULT WINAPI ImageListImpl_Add(IImageList *iface, HBITMAP hbmImage,
>      HBITMAP hbmMask, int *pi)
>  {
> -    FIXME("STUB: %p %p %p %p\n", iface, hbmImage, hbmMask, pi);
> -    return E_NOTIMPL;
> +    HIMAGELIST This = (HIMAGELIST) iface;
> +    int ret;
> +
> +    if (!This || !hbmImage || !pi)
> +        return E_FAIL;

It doesn't make sense to check the interface pointer, it can't be NULL.

Also please don't resend the full series once again, when things don't
get committed on the first try you need to proceed in smaller steps.

-- 
Alexandre Julliard
julliard(a)winehq.org