Re: [1/5] wsdapi: Implement WSD LinkedMemory functions [try 4]

[Alexandre Julliard]

Owen Rudge <orudge(a)codeweavers.com> writes:
> +    ptr = HeapAlloc(procHeap, HEAP_ZERO_MEMORY, MEMORY_ALLOCATION_SIZE + cbSize);

Are all allocations supposed to be zeroed?  This is a little surprising,
it would need a test too.
> +
> +    srand((unsigned)time(NULL));

Please don't do that, test results need to be reproducible.

-- 
Alexandre Julliard
julliard(a)winehq.org

[1/5] wsdapi: Implement WSD LinkedMemory functions [try 4]

[Owen Rudge]

On 02/05/2017 21:49, Alexandre Julliard wrote:
> Are all allocations supposed to be zeroed? This is a little surprising,
> it would need a test too.

Good point - it seems not. I can't think how I could write a test to 
reliably prove that the allocation shouldn't be zeroed (as occasionally 
by chance it will be), so I presume I should be OK to just amend the 
implementation to remove the zeroing.
> Please don't do that, test results need to be reproducible.

Sorry, I'll submit an amended test to fix that.

Thanks,

-- 
Owen Rudge
http://www.owenrudge.net/