Re: [PATCH 5/5] ddraw/tests: Add tests for DDBLT_ROP.

[Matteo Bruni]

2015-03-16 14:48 GMT+01:00 Stefan Dösinger <stefan(a)codeweavers.com>:
> ---
>  dlls/ddraw/surface.c      | 16 ++++++++
>  dlls/ddraw/tests/ddraw7.c | 98 +++++++++++++++++++++++++++++++++++++++--------
>  2 files changed, 98 insertions(+), 16 deletions(-)

This patch also changes the implementation while the title suggests
only additions to the tests. This might come as a surprise a few
months down the line in the (admittedly unlikely) case this causes
regressions or something similar, so I'd either change the name of the
patch or split the implementation change from the test part. Again,
it's not that important in this specific case so I don't care much.

[PATCH 5/5] ddraw/tests: Add tests for DDBLT_ROP.

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2015-03-16 um 17:43 schrieb Matteo Bruni:
> This patch also changes the implementation while the title
> suggests only additions to the tests. This might come as a surprise
> a few months down the line in the (admittedly unlikely) case this
> causes regressions or something similar, so I'd either change the
> name of the patch or split the implementation change from the test
> part. Again, it's not that important in this specific case so I
> don't care much.
> I guess you're right, I'll send a patch with an updated title.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2

iQIcBAEBAgAGBQJVBwmEAAoJEN0/YqbEcdMwW7MP+wXX6Nyh1PS4sK7bi/aesiH8
0Q/kKBzzoqQmN0pyejKoYn7B6/BNbP1Fuq/m7asTfzu0lxE5xq/fjr+rmI9HFlDR
xplPKuIcDeuoP71wViVrV8utbvUzz4uvFisKHZTecXfm2ZHFokq67Fna7x9fXHLT
chXgYdwpnilfw/UeKBrq6rtJLDLHYp/6VsClT0DR+Hk6ZShJGMS9/tK6/cN00q34
Gob3R1dpbwxiGW0Zr0A9sqr1V0ekr1rb7dW3n8WLTVi2SlX7NdM0tjaCRwKJTGsS
KD3zzA6lEXiqL3/dK2Gbi6yS45oM/k12zOllNrWHnl4G5qPeHTYBvzvyOwiaHJpZ
LN1f8nI9GYeUmoQvRANcyBk1pyr2CxjzCP5X3ICSG/nCjCgOX01mpdS5KV+EYnnR
3UQUW3AG5lRDLfw9qeH1coTX1Bzb1LC5cDDTyw56CF2R6jKzw76FQJ+nIHkyNjjH
aUfqK8zCTC7M3pn/snaV6cF8wuk0J0AhpW1NscDhl5tF7mJjVQ8gHUtWFXHb6Eb+
H9GDJPj8uovj6o3aKuhGlIcV6BqUdAPzsGnKUAkcBpSzB2CWFMbb8DSI+TEkLYTt
QduqeRbktwCyQPQoH7Cuug/ET625Pf9RNQnPoIvGnrff29Ybyos+fYP+E4rlIrcK
TBHJ5s4cYy5NJtnGlVO7
=i6iF
-----END PGP SIGNATURE-----