Re: [PATCH 5/5] wined3d: Remove the version parameter.

[Henri Verbeet]

On 16 March 2014 20:39, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
> diff --git a/include/wine/wined3d.h b/include/wine/wined3d.h
> index 7bb37d6..df725e2 100644
> --- a/include/wine/wined3d.h
> +++ b/include/wine/wined3d.h
> @@ -1221,6 +1221,7 @@ enum wined3d_display_rotation
>  #define WINED3D_NO3D                                            0x00000002
>  #define WINED3D_VIDMEM_ACCOUNTING                               0x00000004
>  #define WINED3D_PRESENT_CONVERSION                              0x00000008
> +#define WINED3D_ALLOW_3D_DISABLE                                0x00000010

Do we really need this? It's perhaps unfortunate that setting
"DirectDrawRenderer" to "gdi" would also prevent 3D in d3d8+, but I'm
not sure if avoiding that is really worth an extra flag.

[PATCH 5/5] wined3d: Remove the version parameter.

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2014-03-17 10:41, schrieb Henri Verbeet:
> Do we really need this? It's perhaps unfortunate that setting 
> "DirectDrawRenderer" to "gdi" would also prevent 3D in d3d8+, but
> I'm not sure if avoiding that is really worth an extra flag.
> Maybe not. Although we could think this one step further and consider
> removing the key and instead implement this functionality with an
> opengl32.dll = disabled override.

Please ignore this patch for now. I'll investigate how well the
opengl32 override works for this purpose.

There's the theoretical possibility that an application uses d3d8 for
main rendering and ddraw for GPU detection that fails for some reason
without DirectDrawRenderer=gdi, but that would be a bug that needs a
fix elsewhere.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJTJs+fAAoJEN0/YqbEcdMwRJEP/jRSnlEWx3FLLniEANnPPNan
hjjTQhnz1xozpuy6gK77scq7fbmtrzCnQkn3UH1vtDZUMTCLqAcwTOeTRoxI7rFN
+dGXw/wfx0TDWcy6ppRtymGt0mHFvwmWb3R1RlH0j0YpspLNfDfB+DzG7n9j8qAU
Ebr12OL5C2kkXBHxhH1+QtCtQIFnQmuCnTqUeOkuMT7Tm+OKmXKmAB6zWhjoXvCS
IvP/y3KPErV2wMKeyd2phJLcZARtIrYzZj+u+KXvWZJCMgtXRf2PLmLTn7vFcjjX
0OY1uantYfUFIQa0GfXBDse3eyNCvClntTa858H4jthkudXznCDDxovCiOFM+6dC
PKwoGsKzJFYUSyAeTFPoJBZo86W1S3Sm4eDtbfS1Omu/l+VJzvI3Jixt7nDPaZzt
RB2tKeTCzBQJAyRfTcNndtiOW5y6gr5vOQk3ItCdtKsFrrASQNQcR98XMTkyxjqT
UNTQPdGBn9cDQ6jJ/MJVbZOECQRk36kHrXog/YU6bkfTaaE6UWaHIEW+ORJJD2Hu
4ujmBU1qDyewDVYDkoBR3Di7r10LEB7ZcE3ek8vsxDSmJUiauDKR0wdI0CfS+CJH
Wn+I3hoGXrmqvD4TcmlYGztP9orUfMj7WmLxf6rQSYh+UVsqICTS/LEi9YEGEb3G
vsRm7iV1Dm8vKGEkeZ+2
=MlBb
-----END PGP SIGNATURE-----

[PATCH 5/5] wined3d: Remove the version parameter.

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2014-03-17 11:34, schrieb Stefan Dösinger:
> Although we could think this one step further and consider removing
> the key and instead implement this functionality with an 
> opengl32.dll = disabled override.
> Actually, this might not be a good idea. There's still the use case of
> using our ddraw on Windows with 2D only support where dll overrides
> are not available.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.22 (GNU/Linux)
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJTJulkAAoJEN0/YqbEcdMw7VQP/Aw0dNTVwrLvHSh7V8Z8qzQe
RZfjbvb4BfcpdwtJBh2qRO5rCLqc127WbID8rq032WVxKohKGfWq+yMFdIk6XJCV
nUo6E/a4jhYE/02zPrN5hjquxD4jV4VGhb4kHh72Lj1gs6aDqgXQzEqEy7ct7EXK
fFlQLwLdaeEeRbsv13a/gwuW99wG6tRkYopgdMZU2neYdA6Ps39DOOz/y3kWwW+o
+gTyQHbm2BSZfoDK902UFbknQZ+Gq8JhJn0Q+GgEAA839kixLmUvxj+3vABUw7C6
Y+Jf5LJ6ueLlOtglVDDqCniXRM6Pfu8PEaYACY+75pdU88Q5OT0ZTlfJGadnsw55
WXs7w4QSD4BoZuHC8Z6DPCxCaFc0xM6BfkmhoOzgaaU6ncP2nYX4llEf7zKLvsXj
BgR1/VC7PfNv0WPb7s8mqV7f+ZmO/M6jJzZoWjuHSG7lgG20eT78PrJUPtEFn/uk
qUC99oliodxKtKr5lgCYFFdyZeFkdeMPDGmJCq7WZeWicxbVdT2o1Fr6x6r1EJXA
byI6h8jLjZ51ldlKNNvTIgVCJ7BQxi+WJ02TS7oYIhtzlJbL5U3Ov5NJ50qDMPoN
lGrZTIcKJeiklTai2bE0hYzlYp/5EZTz+mGASEu9t7k52WtSSQZoc3LHDYD7ZzwM
qoUhn+QhMf5rj2BDH2mF
=6hcr
-----END PGP SIGNATURE-----