Re: [1/3][resend] wined3d: Allowing infinity count of backbuffers

[paulo lesgaz]

--- En date de : Mer 24.6.09, Henri Verbeet <hverbeet(a)gmail.com> a écrit :

De: Henri Verbeet <hverbeet(a)gmail.com>
Objet: Re: [1/3][resend] wined3d: Allowing infinity count of backbuffers
À: wine-devel(a)winehq.org
Date: Mercredi 24 Juin 2009, 11h13

2009/6/24 Pavel Procházka <pavelvonlostice(a)seznam.cz>:
>

Please set a proper subject on your mails. I think this has been asked before.

You can't just remove the check without making it work first, the
patch has to make sense on its own.

I don't get what you mean. Do you suggest that Pavel merges the two first patches in one single, with a title like "Allows multibuffering in ddraw" ?

David

[1/3][resend] wined3d: Allowing infinity count of backbuffers

[Stefan Dösinger]

Am Wednesday 24 June 2009 12:11:17 schrieb paulo lesgaz:
> 2009/6/24 Pavel Procházka <pavelvonlostice(a)seznam.cz>:
>
> Please set a proper subject on your mails. I think this has been asked
> before.
>
> You can't just remove the check without making it work first, the
> patch has to make sense on its own.
>
> I don't get what you mean. Do you suggest that Pavel merges the two first
> patches in one single, with a title like "Allows multibuffering in ddraw" ?
> Actually, the check removed by this patch doesn't "protect" against hitting 
> the not quite working code in swapchain_gdi.c. We already allow up to 4 
> backbuffers, which is already broken in swapchain.c. The check is here 
> because d3d9(according to msdn) doesn't allow more than 4 back buffers.