Re: include/wine/debug.h: ... and uses of '_ONCE' variants.
Please discard this series of patches. They will not work with compilers that do not support macros with variable numbers of arguments. While most modern compilers do provide variadic macros, some older compilers do not. To do this right a non-intuitive syntax would be required. (i.e. 'FIXME_ONCE((...));'.) Also, the current implementation is imperfect. There should be a test in 'configure' for the various kinds of variadic macro support and the conditionals should be based on what configure finds, not on the use of any particular compiler. -Max
Max TenEyck Woodbury <max(a)mtew.isa-geek.net> writes:
Also, the current implementation is imperfect. There should be a test in 'configure' for the various kinds of variadic macro support and the conditionals should be based on what configure finds, not on the use of any particular compiler.
No, the current implementation is correct, debug.h should be usable from Winelib apps where you don't have access to Wine configure checks. -- Alexandre Julliard julliard(a)winehq.org
On 07/22/2010 03:35 AM, Alexandre Julliard wrote:
Max TenEyck Woodbury<max(a)mtew.isa-geek.net> writes:
Also, the current implementation is imperfect. There should be a test in 'configure' for the various kinds of variadic macro support and the conditionals should be based on what configure finds, not on the use of any particular compiler.
No, the current implementation is correct, debug.h should be usable from Winelib apps where you don't have access to Wine configure checks.
Ahh. Should the list of compilers that support varadic macros be updated?
Max TenEyck Woodbury <max(a)mtew.isa-geek.net> writes:
No, the current implementation is correct, debug.h should be usable from Winelib apps where you don't have access to Wine configure checks.
Ahh. Should the list of compilers that support varadic macros be updated?
If you have a compiler that you have verified works properly and is not covered by the existing cases, sure. -- Alexandre Julliard julliard(a)winehq.org
participants (2)
-
Alexandre Julliard -
Max TenEyck Woodbury