[PATCH] ntdll: Avoid repeated FIXME messages in NtQueryInformationThread
From: Qais Patankar <qaisjp(a)gmail.com> This complements commit 01c2af446a325bcb5535ee1665a4abc7fa99c2fd which was intended to make the messages from #36821 less noisy. The messages now made less noisy are of this pattern: 003f:fixme:thread:NtQueryInformationThread info class 22 not supported yet Links: - https://source.winehq.org/git/wine.git/commitdiff/01c2af446a325bcb5535ee1665... - https://bugs.winehq.org/show_bug.cgi?id=36821 --- dlls/ntdll/thread.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dlls/ntdll/thread.c b/dlls/ntdll/thread.c index f837062..8929033 100644 --- a/dlls/ntdll/thread.c +++ b/dlls/ntdll/thread.c @@ -1073,7 +1073,8 @@ NTSTATUS WINAPI NtQueryInformationThread( HANDLE handle, THREADINFOCLASS class, case ThreadPriorityBoost: case ThreadSetTlsArrayAddress: default: - FIXME( "info class %d not supported yet\n", class ); + static int once; + if (!once++) FIXME( "info class %d not supported yet\n", class ); return STATUS_NOT_IMPLEMENTED; } } -- 2.21.0
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=53867 Your paranoid android. === debian9 (build log) === ../../../wine/dlls/ntdll/thread.c:1076:9: error: a label can only be part of a statement and a declaration is not a statement Makefile:895: recipe for target 'thread.o' failed Makefile:8495: recipe for target 'dlls/ntdll' failed Task: The win32 build failed
participants (2)
-
Marvin -
qaisjp@gmail.com