Re: gitignore: ignore files generated by the Visual C++ compiler.

[Dmitry Timoshkov]

"Reece Dunn" <msclrhd(a)googlemail.com> wrote:
> This patch ignores any files generated by the Visual C++ compiler to
> make it easier to generate patches when using the VCExpress family of
> compilers on Windows.

There is no point in that, patches should be generated after testing
in Wine under a supported platform.

-- 
Dmitry.

gitignore: ignore files generated by the Visual C++ compiler.

[Uwe Bonnes]

> > > > > "Dmitry" == Dmitry Timoshkov <dmitry(a)codeweavers.com> writes:

Dmitry> "Reece Dunn" <msclrhd(a)googlemail.com> wrote:
    >> This patch ignores any files generated by the Visual C++ compiler to
    >> make it easier to generate patches when using the VCExpress family of
    >> compilers on Windows.

    Dmitry> There is no point in that, patches should be generated after
    Dmitry> testing in Wine under a supported platform.

That sounds like a Microsoft requirement...

-- 
Uwe Bonnes                bon(a)elektron.ikp.physik.tu-darmstadt.de

Institut fuer Kernphysik  Schlossgartenstrasse 9  64289 Darmstadt
--------- Tel. [phone] -------- Fax. [phone] ----------

gitignore: ignore files generated by the Visual C++ compiler.

[Reece Dunn]

On 24/01/2008, Dmitry Timoshkov <dmitry(a)codeweavers.com> wrote:
> "Reece Dunn" <msclrhd(a)googlemail.com> wrote:
> > This patch ignores any files generated by the Visual C++ compiler to
> > make it easier to generate patches when using the VCExpress family of
> > compilers on Windows.
>
> There is no point in that, patches should be generated after testing
> in Wine under a supported platform.

If you are in a bash/cmd shell *on Windows* with a checked out
wine.git repository, and you are using VCExpress to *build and test*
the /tests/ that test the Windows platforms (that is, you either don't
have access to mingw, or want to make use of the debugging
facilities), your work flow is something like this:

    vim edit.c
    cl ../../../include $(VCDIR)/include user32.lib gdi32.lib edit.c
    ./edit.exe

and when everything is ok:

    git add . && git status
    git commit -m "user32: fixed edit for <insert Windows OS version here>."

which won't work in this case, as the files that cl generates will be
added into the local repository.

To test this on Wine, you would pull those changes to the Linux
machine with Wine setup (after you have committed the files!) and test
it there.

NOTE: The website at
http://winehq.org/site/docs/winedev-guide/testing-windows - "5.5.
Building and running the tests on Windows", has a section entitled
"5.5.4. Standalone, using the Microsoft C++ Toolkit", so this *is* a
valid development platform, so this patch *is* valid.

- Reece

gitignore: ignore files generated by the Visual C++ compiler.

[Alexandre Julliard]

"Reece Dunn" <msclrhd(a)googlemail.com> writes:
> and when everything is ok:
>
> git add . && git status
>     git commit -m "user32: fixed edit for <insert Windows OS version here>."
>
> which won't work in this case, as the files that cl generates will be
> added into the local repository.

You should add them to your global .gitignore.

-- 
Alexandre Julliard
julliard(a)winehq.org

gitignore: ignore files generated by the Visual C++ compiler.

[Reece Dunn]

On 24/01/2008, Alexandre Julliard <julliard(a)winehq.org> wrote:
> "Reece Dunn" <msclrhd(a)googlemail.com> writes:
> > and when everything is ok:
> >
> > git add . && git status
> >     git commit -m "user32: fixed edit for <insert Windows OS version here>."
> >
> > which won't work in this case, as the files that cl generates will be
> > added into the local repository.
>
> You should add them to your global .gitignore.

I'll do that, then. You can ignore this patch.

What about the other patches?

- Reece

gitignore: ignore files generated by the Visual C++ compiler.

[Francois Gouget]

On Thu, 24 Jan 2008, Reece Dunn wrote:
[...]
> and when everything is ok:
>
> git add . && git status
>     git commit -m "user32: fixed edit for <insert Windows OS version here>."
>
> which won't work in this case, as the files that cl generates will be
> added into the local repository.

Then just specify which files to commit. Should be easy as when working 
on tests there's usually few modified files.

   git commit -m "user32: fixed edit for xxx" dlls/user32/tests/xxx.c

-- 
Francois Gouget <fgouget(a)free.fr>              http://fgouget.free.fr/
  Good judgment comes from experience, and experience comes from bad judgment
                               -- Barry LePatner

gitignore: ignore files generated by the Visual C++ compiler.

[Kai Blin]

On Thursday 24 January 2008 18:07:57 Reece Dunn wrote:
> If you are in a bash/cmd shell *on Windows* with a checked out
> wine.git repository, and you are using VCExpress to *build and test*
> the /tests/ that test the Windows platforms (that is, you either don't
> have access to mingw, or want to make use of the debugging
> facilities), your work flow is something like this:
>
> vim edit.c
>     cl ../../../include $(VCDIR)/include user32.lib gdi32.lib edit.c
>     ./edit.exe

That's more or less they way I do it, just that I do the compile using the 
msvc6 compiler under Wine on Linux. :)
> and when everything is ok:
>
> git add . && git status
>     git commit -m "user32: fixed edit for <insert Windows OS version
> here>."

I'd like to take this opportunity to advertize git add --interactive. I think 
you need a 1.5.3.x git but git add --interactive is a tool I really don't 
want to miss anymore.

Cheers,
Kai

-- 
Kai Blin
WorldForge developer  http://www.worldforge.org/
Wine developer        http://wiki.winehq.org/KaiBlin
Samba team member     http://www.samba.org/samba/team/
--
Will code for cotton.