Re: dplayx: Fix static overrun of pDP array in test. (Coverity)
On Thursday 11 September 2008 20:50:58 Ismael Barros wrote:
On 9/10/08, Kai Blin <kai.blin(a)gmail.com> wrote:
--- dlls/dplayx/tests/dplayx.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Sorry for the delay, I should have checked this before. I hadn't even read the coverity thread.
The patch is incorrect, because EnumSessions_cb_join always receives a LPDIRECTPLAY4 as lpContext argument, even if most callbacks receive a lpCallbackData. The initialization of callbackData before the call was an error on my side.
This patch fixes the double error.
Just the reason why I cc'ed you on this patch. :) Thanks, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.
participants (1)
-
Kai Blin