Re: [PATCH 6/7] urlmon: Report redirected URL to object created by BindToObject.

[Paul Vriens]

On 12/15/2009 09:16 PM, Jacek Caban wrote:
> ---
> dlls/urlmon/binding.c | 6 +++++
> dlls/urlmon/tests/url.c | 58 ++++++++++++++++++++++++++++++----------------
> 2 files changed, 44 insertions(+), 20 deletions(-)

Hi Jacek,

This one introduced a test failure:

http://test.winehq.org/data/tests/urlmon:url.html

I didn't find anything common for the boxes/OS, race?

Could you have a look?

-- 
Cheers,

Paul.

[PATCH 6/7] urlmon: Report redirected URL to object created by BindToObject.

[Marcus Meissner]

On Wed, Dec 16, 2009 at 07:30:22PM +0100, Paul Vriens wrote:
> On 12/15/2009 09:16 PM, Jacek Caban wrote:
> > ---
> > dlls/urlmon/binding.c | 6 +++++
> > dlls/urlmon/tests/url.c | 58 ++++++++++++++++++++++++++++++----------------
> > 2 files changed, 44 insertions(+), 20 deletions(-)
>
> Hi Jacek,
>
> This one introduced a test failure:
>
> http://test.winehq.org/data/tests/urlmon:url.html
>
> I didn't find anything common for the boxes/OS, race?
>
> Could you have a look?

I saw lots of heap corruptions scroll by.

Did not debug further.

Ciao, Marcus

[PATCH 6/7] urlmon: Report redirected URL to object created by BindToObject.

[Jacek Caban]

On 12/16/09 7:50 PM, Marcus Meissner wrote:
> On Wed, Dec 16, 2009 at 07:30:22PM +0100, Paul Vriens wrote:
> > On 12/15/2009 09:16 PM, Jacek Caban wrote:
> > > ---
> > > dlls/urlmon/binding.c | 6 +++++
> > > dlls/urlmon/tests/url.c | 58 ++++++++++++++++++++++++++++++----------------
> > > 2 files changed, 44 insertions(+), 20 deletions(-)
> >
> > Hi Jacek,
> >
> > This one introduced a test failure:
> >
> > http://test.winehq.org/data/tests/urlmon:url.html
> >
> > I didn't find anything common for the boxes/OS, race?
> >
> > Could you have a look?
>
> I saw lots of heap corruptions scroll by.
>
> Did not debug further.

I can't see them here. Could you please send me logs?


Thanks,
     Jacek

[PATCH 6/7] urlmon: Report redirected URL to object created by BindToObject.

[Marcus Meissner]

On Wed, Dec 16, 2009 at 08:06:32PM +0100, Jacek Caban wrote:
> On 12/16/09 7:50 PM, Marcus Meissner wrote:
> > On Wed, Dec 16, 2009 at 07:30:22PM +0100, Paul Vriens wrote:
> > > On 12/15/2009 09:16 PM, Jacek Caban wrote:
> > > > ---
> > > > dlls/urlmon/binding.c | 6 +++++
> > > > dlls/urlmon/tests/url.c | 58 ++++++++++++++++++++++++++++++----------------
> > > > 2 files changed, 44 insertions(+), 20 deletions(-)
> > >
> > > Hi Jacek,
> > >
> > > This one introduced a test failure:
> > >
> > > http://test.winehq.org/data/tests/urlmon:url.html
> > >
> > > I didn't find anything common for the boxes/OS, race?
> > >
> > > Could you have a look?
> > > I saw lots of heap corruptions scroll by.
> >
> > Did not debug further.
>
> I can't see them here. Could you please send me logs?

Worked better today I am afraid. Could really be a load issue :/

Ciao, Marcus

[PATCH 6/7] urlmon: Report redirected URL to object created by BindToObject.

[Jacek Caban]

On 12/16/09 7:30 PM, Paul Vriens wrote:
> On 12/15/2009 09:16 PM, Jacek Caban wrote:
> > ---
> > dlls/urlmon/binding.c | 6 +++++
> > dlls/urlmon/tests/url.c | 58 
> > ++++++++++++++++++++++++++++++----------------
> > 2 files changed, 44 insertions(+), 20 deletions(-)
>
> Hi Jacek,
>
> This one introduced a test failure:
>
> http://test.winehq.org/data/tests/urlmon:url.html
>
> I didn't find anything common for the boxes/OS, race?

Yes, looks like tests take a bit longer and connection cache releases 
the connection. I've sent a patch.

Thanks,
     Jacek