IPinImpl_QueryInternalConnections() is unused

[Francois Gouget]

dlls/qcap/pin.c defines an IPinImpl_QueryInternalConnections() function 
but it is not actually used anywhere. Is there any reason to keep it?

It sort of looks like IPin is a virtual class and that 
IPin::QueryInternalConnections() is going to be implemented in its 
descendents like VfwPin as is currently the case. But then 
VfwPin_QueryInternalConnections() is just as much of a stub so maybe it 
is it that should go away?

-- 
Francois Gouget <fgouget(a)free.fr>              http://fgouget.free.fr/
        A polar bear is a cartesian bear after a coordinate transform.

[Maarten Lankhorst]

Hi Francois,

2009/2/4 Francois Gouget <fgouget(a)free.fr>:
> dlls/qcap/pin.c defines an IPinImpl_QueryInternalConnections() function
> but it is not actually used anywhere. Is there any reason to keep it?
>
> It sort of looks like IPin is a virtual class and that
> IPin::QueryInternalConnections() is going to be implemented in its
> descendents like VfwPin as is currently the case. But then
> VfwPin_QueryInternalConnections() is just as much of a stub so maybe it
> is it that should go away?

qcap/pin.c is just a copy of quartz/pin.c with some things removed,
and it wasn' t kept up to date. I wouldn' t be surprised if it defined
some methods not being used.

Cheers,
Maarten.