Re: [PATCH 1/5] mpr: Implement local name automatic redirection for disks. (try 6)

[Pierre Schweitzer]

Le 10/08/2016 à 17:31, Bruno Jesus a écrit :
> On Mon, Aug 8, 2016 at 7:09 AM, Pierre Schweitzer <pierre(a)reactos.org> wrote:
> > This is a purely cosmetic change, as I had the opportunity to resend. I
> > use uppercase letters instead of lowercase.
> > --
> > Pierre Schweitzer <pierre at reactos.org>
> > System & Network Administrator
> > Senior Kernel Developer
> > ReactOS Deutschland e.V.
>
> Hiho, can you tell me how do we test this patches? Maybe with real
> testing we can convince Alexandre to have the patches commited.

Hi,

Unfortunately, there's no easy way to test them, especially in Wine, as
it comes without network provider.

At the moment, the tests I'm doing are the following:
- I developped a "net use" application against Windows 2003 (ie, it
works in Windows 2003 as the native app - minus a few features I don't
need yet):
https://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/...
- This "net use" application obviously relies on MPR functions I'm
working with.
- I install an instance of ReactOS in VirtualBox/VMware and I try the
various functions of net use, such as:
* net use z: \\UNC path (it must mount the remote UNC path and try to
assign the z: drive letter. As net use command has no idea about network
providers or whatever, it requires the second patch in row which allows
selecting the good network provider (in MPR) to perform the connection).
* net use * \\UNC path (it must mount the remote UNC path and
automatically assign a local drive letter). Typically, that's the patch
you're replying to. It will attempt all the drive letters till one
works. That one is also important because my net use implementation
mimics the MS implementation: when connection is done with automatic
drive letter selection, net use must write connection that was
established (remote UNC to local letter), so it allows testing the
return of the WNetUseConnection function: which is the local drive
used). This is also covered by the 5th patch.
net use z: /delete (it must cancel the connection). This covers the
patches 3 and 4 of the serie.

Note that I also have patches to implement connected resources
enumeration (which is working nicely :-)), but I didn't submit them yet
to Wine, waiting for these 5 patches to make it. This is for the "net
use" and "net use z:" command.

For the network provider "proper" implementation, I rely on open source
software, known to work in Windows, such as VirtualBox guest additions
(https://www.virtualbox.org/browser/vbox/trunk/src/VBox/Additions/WINNT/Share...)
and Winfsp (https://github.com/billziss-gh/winfsp/blob/master/src/dll/np.c).
Screenshots here can give you an overview of what can Wine MPR achieve
now: https://twitter.com/HeisSpiter/media ;-).

I'll do a resend tonight to address a few style comments I received on
#winehackers today (thanks!).

Thanks for your help on this!
> Best wishes,
> Bruno

-- 
Pierre Schweitzer <pierre at reactos.org>
System & Network Administrator
Senior Kernel Developer
ReactOS Deutschland e.V.