Re: wine/dlls/shell32 tests/shellpath.c version.h - IE6 breakage
The following seemingly simple and harmless change caused a regression in IE6. The toolbar icons are no longer displayed and the error message below appears in the log. err:imagelist:ImageList_LoadImageW Error loading image! Mike Alexandre Julliard wrote:
ChangeSet ID: 14326 CVSROOT: /opt/cvs-commit Module name: wine Changes by: julliard(a)wine.codeweavers.com 2004/10/26 16:17:50
Modified files: dlls/shell32/tests: shellpath.c dlls/shell32 : version.h
Log message: Juan Lang <juan_lang(a)yahoo.com> Update shell32's version to WinXP level.
Patch: http://cvs.winehq.org/patch.py?id=14326
Old revision New revision Changes Path 1.3 1.4 +0 -2 wine/dlls/shell32/tests/shellpath.c 1.1 1.2 +4 -4 wine/dlls/shell32/version.h
Am Dienstag, 30. November 2004 06:24 schrieb Mike McCormack:
The following seemingly simple and harmless change caused a regression in IE6. The toolbar icons are no longer displayed and the error message below appears in the log. I can confirm the symptom. I'll test if reversing the patch helps for me.
Stefan Dösinger
Am Dienstag, 30. November 2004 06:24 schrieb Mike McCormack:
The following seemingly simple and harmless change caused a regression in IE6. The toolbar icons are no longer displayed and the error message below appears in the log.
I can confirm the symptom. I'll test if reversing the patch helps for me. Reversing the patch fixes the problem. Perhaps we should set the shell32 version according to the configured Windows version.
Stefan
Hi, On Tue, Nov 30, 2004 at 02:24:37PM +0900, Mike McCormack wrote:
The following seemingly simple and harmless change caused a regression in IE6. The toolbar icons are no longer displayed and the error message below appears in the log.
err:imagelist:ImageList_LoadImageW Error loading image!
It's probably not a "regression" in the standard sense, I guess. Rather something like IE6 choosing to use more modern API mechanisms or a different execution path due to the higher version number we just set. IOW, we should fix Wine to support these API updates. Andreas Mohr
"Andreas Mohr" <andi(a)rhlx01.fht-esslingen.de> wrote:
On Tue, Nov 30, 2004 at 02:24:37PM +0900, Mike McCormack wrote:
The following seemingly simple and harmless change caused a regression in IE6. The toolbar icons are no longer displayed and the error message below appears in the log.
err:imagelist:ImageList_LoadImageW Error loading image!
It's probably not a "regression" in the standard sense, I guess.
Rather something like IE6 choosing to use more modern API mechanisms or a different execution path due to the higher version number we just set.
IOW, we should fix Wine to support these API updates.
Of course Wine should be fixed. But until then the patch should be reverted. That's exactly the same kind of patch like adding a stub to a .spec file, and upgrading a dll version is not really harmless as it seems at the first glance. -- Dmitry.
Dmitry Timoshkov wrote:
"Andreas Mohr" <andi(a)rhlx01.fht-esslingen.de> wrote:
On Tue, Nov 30, 2004 at 02:24:37PM +0900, Mike McCormack wrote:
The following seemingly simple and harmless change caused a regression in IE6. The toolbar icons are no longer displayed and the error message below appears in the log.
err:imagelist:ImageList_LoadImageW Error loading image!
It's probably not a "regression" in the standard sense, I guess.
Rather something like IE6 choosing to use more modern API mechanisms or a different execution path due to the higher version number we just set.
IOW, we should fix Wine to support these API updates.
Of course Wine should be fixed. But until then the patch should be reverted. That's exactly the same kind of patch like adding a stub to a .spec file, and upgrading a dll version is not really harmless as it seems at the first glance.
WinXP stores the toolbar bitmaps in shell32 in WinXP. I assume previous versions, stored them in some other DLL. Rob
--- Mike McCormack <mike(a)codeweavers.com> wrote:
The following seemingly simple and harmless change caused a regression in IE6. The toolbar icons are no longer displayed and the error message below appears in the log.
Interesting. My preference would have been to use Win2K's shell32 version, but I didn't have Win2K handy. If you happen to know its version, that'd be cool. --Juan __________________________________ Do you Yahoo!? Yahoo! Mail - Helps protect you from nasty viruses. http://promotions.yahoo.com/new_mail
participants (6)
-
Andreas Mohr -
Dmitry Timoshkov -
Juan Lang -
Mike McCormack -
Robert Shearman -
Stefan Dösinger