[PATCH 5/7] scrobj: Lookup object members implementations in scripts when createating scriptlet instance.
Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> --- dlls/scrobj/scrobj.c | 92 ++++++++++++++++++++++++++++++++++++++ dlls/scrobj/tests/scrobj.c | 9 ---- 2 files changed, 92 insertions(+), 9 deletions(-)
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=56947 Your paranoid android. === debian10 (32 bit report) === scrobj: scrobj.c:890: Test succeeded inside todo block: id = 6421816, expected 6421816 === debian10 (32 bit French report) === scrobj: scrobj.c:890: Test succeeded inside todo block: id = 6421816, expected 6421816 === debian10 (32 bit Japanese:Japan report) === scrobj: scrobj.c:890: Test succeeded inside todo block: id = 6421816, expected 6421816 === debian10 (32 bit Chinese:China report) === scrobj: scrobj.c:890: Test succeeded inside todo block: id = 6421816, expected 6421816 === debian10 (32 bit WoW report) === scrobj: scrobj.c:890: Test succeeded inside todo block: id = 6421816, expected 6421816 === debian10 (64 bit WoW report) === scrobj: scrobj.c:890: Test succeeded inside todo block: id = 6421816, expected 6421816
On 9/25/19 9:48 PM, Marvin wrote:
scrobj: scrobj.c:890: Test succeeded inside todo block: id = 6421816, expected 6421816
Because of expected Wine failures, the test compares uninitialized values that happen to have be the same on testbot (they weren't on my box). Patch 6/7 fixes it by implementing GetDispID, which properly initializes problematic variables. Jacek
participants (2)
-
Jacek Caban -
Marvin