Re: [PATCH 1/3] msi: Remove a superfluous substructure and convert its arrays to lists.
On Tue, 2017-09-19 at 00:23 -0500, Zebediah Figura wrote:
+struct action +{ + struct list entry; + WCHAR *action; +}; + typedef struct tagMSIPACKAGE { MSIOBJECTHDR hdr; @@ -403,7 +418,10 @@ typedef struct tagMSIPACKAGE struct list mimes; struct list appids;
- struct tagMSISCRIPT *script; + struct list script_actions[SCRIPT_MAX]; + struct list unique_actions; + BOOL ExecuteSequenceRun; + UINT InWhatSequence;
Why? The package structure is heavy on lists already, some of these should be moved to arrays instead...
On 09/19/2017 04:34 AM, Hans Leidekker wrote:
On Tue, 2017-09-19 at 00:23 -0500, Zebediah Figura wrote:
+struct action +{ + struct list entry; + WCHAR *action; +}; + typedef struct tagMSIPACKAGE { MSIOBJECTHDR hdr; @@ -403,7 +418,10 @@ typedef struct tagMSIPACKAGE struct list mimes; struct list appids;
- struct tagMSISCRIPT *script; + struct list script_actions[SCRIPT_MAX]; + struct list unique_actions; + BOOL ExecuteSequenceRun; + UINT InWhatSequence;
Why? The package structure is heavy on lists already, some of these should be moved to arrays instead...
Oh, I guess I got the impression that lists were preferred. I'll resend without that change, then.
participants (2)
-
Hans Leidekker -
Zebediah Figura